Closed
Bug 830758
Opened 10 years ago
Closed 10 years ago
Pinned sites should not show "pin site" in context menu
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox20 verified, firefox21 verified)
VERIFIED
FIXED
Firefox 21
People
(Reporter: ibarlow, Assigned: wesj)
References
Details
Attachments
(1 file)
1.52 KB,
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Galaxy Nexus running Firefox Aurora 20.0a2 2013-01-15 -- If a site has been pinned, the Pin Site option in the context menu should be replaced by Unpin Site. Currently the menu shows both -- see screenshot http://cl.ly/image/1P2r371K062g
Updated•10 years ago
|
Attachment #703593 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc042a2cc38c
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 703593 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 783312 User impact if declined: Context menu items shown that don't make sense Testing completed (on m-c, etc.): Landed today Risk to taking this patch (and alternatives if risky): Very very low risk and simple. String or UUID changes made by this patch: None. Just hiding strings.
Attachment #703593 -
Flags: approval-mozilla-aurora?
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bc042a2cc38c
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Updated•10 years ago
|
Attachment #703593 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 5•10 years ago
|
||
"Pin Site" option is not displayed anymore for a pinned site on the latest nightly. Firefox for Android Version: 21.0a1 (2013-01-23) Device: Galaxy R OS: Android 2.3.4
status-firefox21:
--- → verified
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/fdcde29caa78
status-firefox20:
--- → fixed
Comment 8•10 years ago
|
||
Cannot reproduce it on Aurora either. Closing bug as verified fixed.
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•