830893 - Zombified tabs lose their private states

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

We destroy tabs and recreate them as zombie tabs here: http://hg.mozilla.org/integration/mozilla-inbound/file/8e7daee5f5a9/mobile/android/chrome/content/browser.js#l8053

In doing so, tabs lose their private state. We should remember them for the zombified tabs.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Remember private state for zombified tabs

Hopefully, this is a dupe of bug 830461.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Remember private state for zombified tabs, v2

Oops, fixed a typo. I'm still doing a full rebuild and haven't been able to test this yet, but I think this should work.

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05e097a70714

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 702438 [details] [diff] [review]
Remember private state for zombified tabs, v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 582244
User impact if declined: zombified private tabs won't actually be private
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/05e097a70714

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 702438 [details] [diff] [review]
Remember private state for zombified tabs, v2

Approving low risk patch, but tracking since this is something we'd really want to know about if there were regressions.

Comment 7

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a43be14ddfb