Closed
Bug 831086
Opened 12 years ago
Closed 11 years ago
[MP] Defect - When in filled or snapped view, Metro Firefox appears squished and has a large black column of unused space
Categories
(Firefox for Metro Graveyard :: Browser, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 27
People
(Reporter: TimAbraldes, Assigned: bbondy)
References
Details
(Whiteboard: [preview] feature=defect c=Browser_views u=metro_firefox_user p=3)
Attachments
(5 files)
No description provided.
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
Updated•12 years ago
|
Reporter | ||
Updated•12 years ago
|
Blocks: metrov1triage
Assignee | ||
Comment 4•12 years ago
|
||
p=2 if it's still reproducible.
Reporter | ||
Comment 5•12 years ago
|
||
I'm not able to reproduce this issue since I switched to a new machine, but others (see bug 860221) have been able to reproduce recently
Updated•12 years ago
|
Summary: When in filled or snapped view, Metro Firefox appears squished and has a large black column of unused space → Defect - When in filled or snapped view, Metro Firefox appears squished and has a large black column of unused space
Whiteboard: feature=defect c=Browser_views u=metro_firefox_user p=0
Updated•12 years ago
|
Whiteboard: feature=defect c=Browser_views u=metro_firefox_user p=0 → feature=defect c=Browser_views u=metro_firefox_user p=2
Updated•12 years ago
|
Priority: -- → P1
Updated•12 years ago
|
Assignee: nobody → sfoster
QA Contact: jbecerra
Updated•12 years ago
|
Status: NEW → ASSIGNED
Comment 7•12 years ago
|
||
I can't reproduce this either. I tried changing the display setting "Size of all items" to 100%, 125%, 150% and 200% to get a range of screen densities. I see no squishing or black gap in filled or snapped view I'm afraid.
Assignee: sfoster → nobody
Status: ASSIGNED → NEW
Comment 8•12 years ago
|
||
Would anyone else like to try to reproduce this bug? If we can't, we can mark it as 'works for me' for now.
Comment 9•12 years ago
|
||
(In reply to Marco Mucci [:MarcoM] from comment #8)
> Would anyone else like to try to reproduce this bug? If we can't, we can
> mark it as 'works for me' for now.
I ran into this issue about a week ago and created Bug 865574 (a duplicate of this one). I can reproduce the issue consistently on my main desktop machine. The only thing that changed would be a few Windows 8 updates but that's pretty much it (haven't installed any new nvidia drivers or anything relating to display that could be causing this issue)
Comment 10•12 years ago
|
||
Thanks Kamil. I'll move this Defect out of the Iteration for now. It can be assigned again for development at any time.
Whiteboard: feature=defect c=Browser_views u=metro_firefox_user p=2 → feature=defect c=Browser_views u=metro_firefox_user p=0
Assignee | ||
Comment 11•12 years ago
|
||
Kamil if you can still reproduce this, can you go to about:support and paste in the section from the Graphics section?
Assignee | ||
Updated•12 years ago
|
Flags: needinfo?(kamiljoz)
Comment 12•12 years ago
|
||
Brian, I can reproduce it every single time on my main machine. I've attached the Graphic information from about:support as a text file. Also attached a screenshot that shows the issue that I am receiving on this machine. (main desktop)
Flags: needinfo?(kamiljoz)
Comment 13•12 years ago
|
||
Assignee | ||
Comment 14•12 years ago
|
||
Thanks!
Assignee | ||
Comment 15•12 years ago
|
||
Nothing unusual about the gfx info Kamil attached, I'll likely have to find hardware or a VM that reproduces this to fix.
Updated•12 years ago
|
Whiteboard: feature=defect c=Browser_views u=metro_firefox_user p=0 → [shovel-ready if repro] feature=defect c=Browser_views u=metro_firefox_user p=0
Comment 16•12 years ago
|
||
Just a quick update, installed the latest nvidia drivers that have been released (320.18) about 2 weeks ago and ran into the same issue. Get these distortions using both "Filled" & "Snapped" views.
Comment 17•11 years ago
|
||
I'm new here and I can reproduce this on my machine always. I'd like to take a shot at this. Brian (or anyone willing) can you point out to me where I start with fixing this and how to write tests? Thanks.
Flags: needinfo?(netzen)
Assignee | ||
Comment 18•11 years ago
|
||
Hey Mina, I'm not sure if you were hoping more for a Javascript bug or not, I suspect this is a C++ problem. In case you're still interested I'd start looking here:
http://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d10/LayerManagerD3D10.cpp#l648
In particular I'd look for errors when resizing or the wrong values being passed there.
Flags: needinfo?(netzen)
Updated•11 years ago
|
Whiteboard: [shovel-ready if repro] feature=defect c=Browser_views u=metro_firefox_user p=0 → feature=defect c=Browser_views u=metro_firefox_user p=0 [shovel-ready if repro]
Updated•11 years ago
|
Whiteboard: feature=defect c=Browser_views u=metro_firefox_user p=0 [shovel-ready if repro] → feature=defect c=Browser_views u=metro_firefox_user p=0 [shovel-ready if repro][preview-triage]
Updated•11 years ago
|
Whiteboard: feature=defect c=Browser_views u=metro_firefox_user p=0 [shovel-ready if repro][preview-triage] → [preview-triage] [shovel-ready if repro] feature=defect c=Browser_views u=metro_firefox_user p=0
Updated•11 years ago
|
Comment 21•11 years ago
|
||
Is anyone still seeing this? some patches landed recently that may have addressed the issue (bug 899435).
Updated•11 years ago
|
Summary: Defect - When in filled or snapped view, Metro Firefox appears squished and has a large black column of unused space → [MP] Defect - When in filled or snapped view, Metro Firefox appears squished and has a large black column of unused space
Whiteboard: [preview-triage] [shovel-ready if repro] feature=defect c=Browser_views u=metro_firefox_user p=0 → [preview] [shovel-ready] feature=defect c=Browser_views u=metro_firefox_user p=0
Comment 22•11 years ago
|
||
Still happening on my main Desktop machine, downloaded the latest build from the following location:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-13-03-02-05-mozilla-central/
Let me know if you would like another screenshot, but the issue is basically the same as all the other screenshots attached above. It only works correctly when Metro is in full view, as soon as you use any other view you will run into the issue
Updated•11 years ago
|
Blocks: MetroPreviewRelease
Comment 23•11 years ago
|
||
Have we figured out what the underlying issue even is?
Whiteboard: [preview] [shovel-ready] feature=defect c=Browser_views u=metro_firefox_user p=0 → [preview] feature=defect c=Browser_views u=metro_firefox_user p=0
Assignee | ||
Comment 24•11 years ago
|
||
No, but if someone can fedex me hardware that can reproduce, I'm pretty sure I can fix it. Asa/Juan/Marco? Will ship back after fixing.
Comment 25•11 years ago
|
||
Hey Brian, I have the laptop kats used - would that work for you? If so, I can ship it out to you.
Assignee | ||
Comment 26•11 years ago
|
||
Hey Marco, Can you reproduce the original issue with this bug? See the screenshots above. It would be awesome if so, and yes I'd like it. But if you can't reproduce with it, then there is no benefit to send it.
Flags: needinfo?(mmucci)
Comment 27•11 years ago
|
||
I will look across all of my machines today and try to reproduce.
Comment 28•11 years ago
|
||
Tested on 2013-09-16. I haven't been able to reproduce this using the latest nightly on my Dell XPS 12 nor my Iconia W3.
Comment 29•11 years ago
|
||
I could not reproduce this bug from the build downloaded here:
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/08/2013-08-13-03-02-05-mozilla-central/firefox-26.0a1.en-US.win64-x86_64.installer.exe
or from the latest build on nightly.mozilla.org
using a Sony Vaio Duo 11
Comment 30•11 years ago
|
||
Hey Brian. Marina was not able to reproduce it on a new device in Toronto. Going to double check with Juan and Asa to see if they can.
Flags: needinfo?(mmucci)
Comment 31•11 years ago
|
||
Hey Juan, can you reproduce this on one of your devices. If so, I'd like to have that device shipped to Brian temporarily to fix it and then it can be returned to you.
Flags: needinfo?(jbecerra)
Comment 32•11 years ago
|
||
I haven't been able to reproduce this on the couple of devices I had access to today.
Flags: needinfo?(jbecerra)
Comment 33•11 years ago
|
||
Thanks for the update Juan.
Asa, your our last hope. :)
Flags: needinfo?(asa)
Comment 34•11 years ago
|
||
I can still reproduce this problem on my desktop machine 100% of the time. I will setup the machine with VS and the required checked out code.
I'll get Brian remote access so he can take a look at the machine and hopefully debug this problem!
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 35•11 years ago
|
||
Clearing needinfo because Kamil got me remote access.
Assignee: nobody → netzen
Status: NEW → ASSIGNED
Flags: needinfo?(asa)
Assignee | ||
Comment 36•11 years ago
|
||
Verified this fixed the problem on the Optimus machine.
Basically we want to resize 2 buffers if we're running immersive firefox and not 1. We want the metro specific handling to override the optimus specific handling.
Attachment #806012 -
Flags: review?(bas)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [preview] feature=defect c=Browser_views u=metro_firefox_user p=0 → [preview] feature=defect c=Browser_views u=metro_firefox_user p=3
Comment 37•11 years ago
|
||
Comment on attachment 806012 [details] [diff] [review]
Patch v1
Review of attachment 806012 [details] [diff] [review]:
-----------------------------------------------------------------
This is correct.
Attachment #806012 -
Flags: review?(bas) → review+
Assignee | ||
Comment 38•11 years ago
|
||
Target Milestone: --- → Firefox 27
Comment 39•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 40•11 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Verified during iteration 15 testing and WFM on latest nightly (build ID: 20130930030205).
The Metro Firefox appears without any UI issues while using both filled and snapped view, it does not appear squished and hasn't any unused space.
Marking as verified.
If someone else is still able to reproduce this, please file a new bug or reopen this issue.
Status: RESOLVED → VERIFIED
Comment 41•11 years ago
|
||
I will also take a look and try it on the machine that I was originally having the issues with when I get home first thing tonight.
Comment 42•11 years ago
|
||
Went through this defect for iteration #15 testing and it generally works pretty well! Most the issues that where occurring on this desktop machines when it came to views have been resolved. Ran into a few more issues but not sure if they are related to the following defect. Created Bug 922456
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•