831215 - Switch on Android noion builds on mozilla-b2g18

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

I've noticed that we don't build Android no-ion on mozilla-b2g18.

cjones, I'm presuming we should?

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Oh golly.  Yes please!

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

(Applies on top of the patch in bug 827540)

Comment 3

[Ed Morley [:emorley]]

Attachment: Patch v2

Comment 4

[Ed Morley [:emorley]]

Cheers :-)

https://hg.mozilla.org/build/buildbot-configs/rev/122c24dffd30

Comment 5

[Aki Sasaki (not active)]

In production.

Comment 6

[Ed Morley [:emorley]]

Hmm this doesn't seem to have worked :-(

Comment 7

[Ed Morley [:emorley]]

I've looked through this several more times and can't find why this isn't working, but other branches are.

Does anyone have any ideas?

Comment 8

[Ed Morley [:emorley]]

No idea why this isn't working; unassigning.

Comment 9

[Chris AtLee [:catlee]]

Attachment: enable 'mobile' product on these branches

for android-noion to be considered, it needs to be picked up by 'enabled_products'

Comment 10

[Ed Morley [:emorley]]

These are now being run correctly - thank you for figuring this out for me catlee :-)

Unfortunately the tests are permacrashing, but 835696 filed for that. Good we've now gotten these turned on!

Comment 11

[Chris AtLee [:catlee]]

Should these be running on other b2g branches as well? (e.g. b2g_v1_0_0, b2g_v1_0_1)?

Comment 12

[Ed Morley [:emorley]]

Yes, I believe they should.

Comment 13

[Chris AtLee [:catlee]]

Callek said he was preparing patches for this.

Comment 14

[Justin Wood (:Callek)]

Attachment: [configs] actually enable on b2g18_v1_0_0 and b2g18_v1_0_1

...I actually rolled a few small corrections to current code + hals v1.0.1 patch while I was in these checks.

I'm happy to leave here or have hal rip out and use in the b2g18_v1_0_1 patch.

This patch is written with 1.0.1 configs (from Bug 835865) applied first.

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 708195 [details] [diff] [review]
[configs] actually enable on b2g18_v1_0_0 and b2g18_v1_0_1

http://hg.mozilla.org/build/buildbot-configs/rev/df45bc4b0592

Comment 16

[Aki Sasaki (not active)]

This is in production.