831348 - messenger.xul: ReferenceError: gDisallow_classes_no_html is not defined

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Philip Chee]

While investigating Bug 831249 I ran into these errors:

Thu Jan 17 2013 00:19:17
Error: ReferenceError: gDisallow_classes_no_html is not defined
Source file: chrome://messenger/content/messenger.xul
Line: 1

Fallout from bug 438429: meta bug to fix several RSS Summary/Web Page bugs.

Suite uses disallow_classes_no_html instead of gDisallow_classes_no_html

Also:

Thu Jan 17 2013 00:40:35
Error: TypeError: this.browsers[i] is undefined
Source file: chrome://navigator/content/tabbrowser.xml
Line: 1077

Comment 1

[Philip Chee]

Attachment: Patch 1.0 Fix it.

Comment 2

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/9876dc5fd507

Comment 3

[Philip Chee]

Comment on attachment 702865 [details] [diff] [review]
Patch 1.0 Fix it.

[Approval Request Comment]
Regression caused by (bug #): Bug 438429
User impact if declined: View-> (Feed) Message Body as... will show all six menu items (both mail/news items and Feed items)
Testing completed (on m-c, etc.): comm-central
Risk to taking this patch (and alternatives if risky): low risk bustage fix.
String changes made by this patch: None.

Note no one complained about this since Bug 438429 landed (SeaMonkey 2.0) so priority is low/ nice to have but not a blocker.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Philip Chee from comment #0)
> Also:
> 
> Thu Jan 17 2013 00:40:35
> Error: TypeError: this.browsers[i] is undefined
> Source file: chrome://navigator/content/tabbrowser.xml
> Line: 1077

Bug 638915. Still.

(In reply to Philip Chee from comment #3)
> User impact if declined: View-> (Feed) Message Body as... will show all six
> menu items (both mail/news items and Feed items)

I cannot seem to reproduce this. Can you expand on the STR?

Comment 5

[Philip Chee]

> I cannot seem to reproduce this. Can you expand on the STR?
Err, now that I've got the patch applied locally I don't have a STR ;P

Comment 6

[Philip Chee]

Pushed to all branches:
http://hg.mozilla.org/releases/comm-aurora/rev/0bdf9bee7863
http://hg.mozilla.org/releases/comm-beta/rev/921f220f5956
http://hg.mozilla.org/releases/comm-release/rev/77eb2bc81830