831373 - Work - Edge-swipe gesture does nothing in snapped view

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1) Put Metro Firefox in snapped view.
2) Perform a swipe gesture from the bottom edge of the screen into the snapped Firefox view.

Expected results: Firefox's appbar(s) are toggled.
Actual results: Nothing happens.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Bug 811417 changed the meaning of "isExpandable" -- previously it just controlled whether the tab appbar could be toggled; now the tab appbar and navigation appbar are always toggled together, so isExpandable controls both.

This code is no longer needed; the #stack[snapped=small] styles in theme/browser.css are enough to keep the context appbar and tab appbar hidden in snapped view.

Comment 2

[Allison Naaktgeboren :ally]

Comment on attachment 703378 [details] [diff] [review]
patch

Review of attachment 703378 [details] [diff] [review]:
-----------------------------------------------------------------

++ for code reduction!
review discussed offline.

for future note: this does not impact the case where the always show tabs pref is enabled.

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/761b623d725d

Comment 4

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.