Closed Bug 831520 Opened 11 years ago Closed 11 years ago

Clear my Metro Firefox History should also clear from StartUI if opened

Categories

(Firefox for Metro Graveyard :: General, defect)

Product:
Firefox for Metro Graveyard
Component:
General
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 21

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2.
4.89 KB, patch
bbondy
: review+
Details | Diff | Splinter Review 
Currently if you clear your browser history from options, it still shows your history on the about:start page.
Whiteboard: [metro-mvp?]
Blocks: 831960
Attached patch Patch v1 (obsolete) — — Splinter Review 
I think we'll want to respond to some of these other notifications on history changes but probably in another bug.
Assignee: nobody → netzen
Attachment #714454 - Flags: review?(mbrubeck)
Comment on attachment 714454 [details] [diff] [review]
Patch v1

Review of attachment 714454 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/bindings/grid.xml
@@ +190,5 @@
>  
> +      <method name="clearAll">
> +        <body>
> +          <![CDATA[
> +            while (this.firstChild) {

Please set "this._contextActions = null;" in this method too.
Attachment #714454 - Flags: review?(mbrubeck) → review+
Attached patch Patch v2. — — Splinter Review 
Carrying forward r+
Attachment #714454 - Attachment is obsolete: true
Attachment #714513 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/0afb667fb4f8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [metro-mvp?]
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: