Closed Bug 831627 Opened 11 years ago Closed 11 years ago

B2G STK: Support "Language Selection Event" Envelope command.

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: allstars.chh, Assigned: chucklee)

References

Details

Attachments

(4 files, 3 obsolete files)

See TS 101.223, clause 7.5.8 Language selection event
Assignee: nobody → chulee
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #0)
> See TS 101.223, clause 7.5.8 Language selection event
Sorry, should be TS 102.223
Attached patch 0001. Add event object. (obsolete) — Splinter Review
Attachment #706925 - Flags: superreview?(jonas)
Attachment #706925 - Flags: review?(allstars.chh)
Attached patch 0001. Add event object, v1.1 (obsolete) — Splinter Review
Add support event list in comment of sendStkEventDownload()
Attachment #706925 - Attachment is obsolete: true
Attachment #706925 - Flags: superreview?(jonas)
Attachment #706925 - Flags: review?(allstars.chh)
Attachment #706930 - Flags: superreview?(jonas)
Attachment #706930 - Flags: review?(allstars.chh)
Comment on attachment 706930 [details] [diff] [review]
0001. Add event object, v1.1

Review of attachment 706930 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/interfaces/SimToolKit.idl
@@ +595,5 @@
> +dictionary MozStkLanguageSelectionEvent
> +{
> +  /**
> +   * The type of this event.
> +   * It shall be nsIDOMMozIccManager.STK_EVENT_TYPE_LANGUAGE_SELECTION;

nit, ends with period.

@@ +602,5 @@
> +
> +  /**
> +   * Language Information
> +   *
> +   * @see ISO 639-1, Alpha-2 code

It would be great if we could put some examples here.
Attachment #706930 - Flags: review?(allstars.chh) → review+
Attachment #706926 - Flags: review?(allstars.chh) → review+
Attachment #706927 - Flags: review?(allstars.chh) → review+
Comment on attachment 706928 [details] [diff] [review]
0004. Test case for Event Download Command : Language Selection.

Review of attachment 706928 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +1569,5 @@
> +  };
> +  worker.RIL.sendStkEventDownload({
> +    event: event
> +  });
> +});

nit, add an extra line here.
Attachment #706928 - Flags: review?(allstars.chh) → review+
Attachment #706930 - Flags: superreview?(jonas) → superreview+
These could use better commit messages (see comment 37 of bug 827280 for examples)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: