831627 - B2G STK: Support "Language Selection Event" Envelope command.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See TS 101.223, clause 7.5.8 Language selection event

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #0)
> See TS 101.223, clause 7.5.8 Language selection event
Sorry, should be TS 102.223

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add event object.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Handle event.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0003. Mark event as supported.

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0004. Test case for Event Download Command : Language Selection.

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add event object, v1.1

Add support event list in comment of sendStkEventDownload()

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 706930 [details] [diff] [review]
0001. Add event object, v1.1

Review of attachment 706930 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/interfaces/SimToolKit.idl
@@ +595,5 @@
> +dictionary MozStkLanguageSelectionEvent
> +{
> +  /**
> +   * The type of this event.
> +   * It shall be nsIDOMMozIccManager.STK_EVENT_TYPE_LANGUAGE_SELECTION;

nit, ends with period.

@@ +602,5 @@
> +
> +  /**
> +   * Language Information
> +   *
> +   * @see ISO 639-1, Alpha-2 code

It would be great if we could put some examples here.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 706928 [details] [diff] [review]
0004. Test case for Event Download Command : Language Selection.

Review of attachment 706928 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +1569,5 @@
> +  };
> +  worker.RIL.sendStkEventDownload({
> +    event: event
> +  });
> +});

nit, add an extra line here.

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0004. Test case for Event Download Command : Language Selection, v1.1

Address comment 8

Comment 10

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add event object, v1.2

Address comment 7

Comment 11

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try server : https://tbpl.mozilla.org/?tree=Try&rev=4f967d3fba82

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7eac60178f6
https://hg.mozilla.org/integration/mozilla-inbound/rev/64b519b7fddf
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecede220333a
https://hg.mozilla.org/integration/mozilla-inbound/rev/3125ccd01edb

Comment 13

[Jeff Muizelaar [:jrmuizel]]

These could use better commit messages (see comment 37 of bug 827280 for examples)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f7eac60178f6
https://hg.mozilla.org/mozilla-central/rev/64b519b7fddf
https://hg.mozilla.org/mozilla-central/rev/ecede220333a
https://hg.mozilla.org/mozilla-central/rev/3125ccd01edb