Click-to-play: Using history.pushState() makes plugin icon in the location bar vanish

VERIFIED FIXED in Firefox 20

Status

()

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

Trunk
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox20 verified, firefox-esr17- affected)

Details

(Whiteboard: [CtPUR:+] [CtPDefault:P2] fixed by bug 825804)

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
When using history.pushState(), the click-to-play plugin icon vanishes from the URL bar even though there still are embed/object elements.

This affects e.g. SoundCloud which seems to have recently switched to using pushState.
(Assignee)

Comment 1

6 years ago
Created attachment 703312 [details]
test case
(Assignee)

Comment 3

6 years ago
Created attachment 703445 [details] [diff] [review]
Use LOCATION_CHANGE_SAME_DOCUMENT

What SeaMonkey does looks cleaner to me and fixes this case.
I think bug 788584 was going to do this, but we never got around to it :-/
(Assignee)

Comment 5

6 years ago
Created attachment 703543 [details] [diff] [review]
Use LOCATION_CHANGE_SAME_DOCUMENT, v2

The change suggested by bug 788584 doesn't fix the vanishing icon, but i guess both could be fixed in one go.
Attachment #703445 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
Created attachment 703880 [details] [diff] [review]
browser-chrome test

This still fails test 4 in browser_popupNotification.js, for which i don't know off-hand what's happing:
https://tbpl.mozilla.org/?tree=Try&rev=8da1a4339b83
Assignee: nobody → georg.fritzsche

Updated

6 years ago
Whiteboard: [CtPUR:+]
(Assignee)

Updated

6 years ago
Whiteboard: [CtPUR:+] → [CtPUR:+] [CtPDefault:P2]

Comment 7

6 years ago
Was this fixed by bug 825804?
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #7)
> Was this fixed by bug 825804?

Yeah, should be fixed.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-firefox20: --- → fixed
Depends on: 825804
Resolution: --- → FIXED
Whiteboard: [CtPUR:+] [CtPDefault:P2] → [CtPUR:+] [CtPDefault:P2] fixed by bug 825804
Target Milestone: --- → mozilla21
Verified fixed FF 20.0a2 (2013-02-18) Win 7
Status: RESOLVED → VERIFIED
status-firefox20: fixed → verified
status-firefox-esr17: --- → affected
tracking-firefox-esr17: --- → ?
We'll track bug 825804 for ESR.
tracking-firefox-esr17: ? → -
You need to log in before you can comment on or make changes to this bug.