832140 - B2G SMS & MMS DB: check event.target.errorCode, return and handle appropriate error codes in callbacks

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Andrew Overholt [:overholt]]

Are you going to do the work here, philikon?

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Andrew Overholt [:overholt] from comment #1)
> blocking-b2g: --- → tef?

Why does this issue deserve a tef?? This task affects almost nothing but more accurate error handling of sms db. Any other reasons?

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2)
> (In reply to Andrew Overholt [:overholt] from comment #1)
> > blocking-b2g: --- → tef?
> 
> Why does this issue deserve a tef?? This task affects almost nothing but
> more accurate error handling of sms db. Any other reasons?

This is marked as blocking bug 823010 which in turns blocks bug 808607.  If this doesn't actually block bug 823010 I'm more than happy to remove the tef? :)

Comment 4

[Gene Lian (I already quit Mozilla)]

Since the DB is shared for SMS and MMS now, the MMS DB callbacks would have the same issue. Please refer to nsIRilMobileMessageDatabaseCallback.

Comment 5

[at-kitamura]

Hi all,

I think that not only the checking event.target.errorCode but also the notifying user has to consider it about this bug.
Because the user cannot notice the reception of the message by the present implementation.
(And error continues being repaid to a server.)

In addition, I think that I have to notify a user without transmitting a message when preservation to DB failed.

Thanks.

Comment 6

[Ken Chang[:kenkai]]

It is necessary for Madai project. Set 1.4+.

Comment 7

[Ken Chang[:kenkai]]

Bevis, after discussing with partners, this is a 1.4+ bug. Please help to fix it.

Comment 8

[Ken Chang[:kenkai]]

To change internal ril interface.

Comment 9

[Ken Chang[:kenkai]]

Blocking LTE feature.

Comment 10

[Ken Chang[:kenkai]]

This is a 1.4+ bug.

Comment 11

[Szu-Yu Chen [:aknow] (inactive)]

Take from Bevis.

Comment 12

[Bevis Tseng[:bevis][:btseng](Exited)]

After confirmed with Szu-Yu, I'd like to take back from Szu-Yu to follow up.

Comment 13

[Bevis Tseng[:bevis][:btseng](Exited)]

For checking the error condition of full storage,
the alternative way is to provide a storage monitor to observe "disk-space-watcher" notification.
Then, always consult the storage monitor before storing sms/mms.

This will be consistent to what user aware from the notification tray and will be helpful to support RIL_REQUEST_REPORT_SMS_MEMORY_STATUS mentioned in bug#739143 in the future.

I'd prefer to apply the alternative one to support the feature in bug#891344 instead.

Comment 14

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 1: Add new error type STORAGE_FULL_ERROR. r=vyang

Comment 15

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2: Add error handling of sending/receiving SMS/MMS when device storage is full. r=vyang

Pre-condition:
1. According to bug#861903 and bug#853350, we know that when device storage is low, indexedDB only allows us for read access.
2. While testing, I found that event.target.errorCode is undefined when we access the indexedDB in storage full condition. No proper error code is available to identify the problem.

Summary of the patch:
1. The main purpose is to add error handling of sending/receiving message while device storage is full.
2. Hence, instead of checking event.target.errorCode, the solution is to apply DiskSpaceWatcher.isDiskFull before any |Write| access to the MobileMessageDatabase and notify STORAGE_FULL_ERROR to the caller.

Comment 16

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8378808 [details] [diff] [review]
Patch Part 1: Add new error type STORAGE_FULL_ERROR. r=vyang

Review of attachment 8378808 [details] [diff] [review]:
-----------------------------------------------------------------

This bug is not for storage full event.  Please move to either bug 891344 or bug 739143.

Comment 17

[Bevis Tseng[:bevis][:btseng](Exited)]

Per discussion offline, 
1. bug 891344 is dedicated for Gaia to fix the problem of 
sending/receiving message while message is full.
2. bug 739143 is more about adopting UNSOLICITED_SIM_SMS_STORAGE_FULL & 
   RIL_REQUEST_REPORT_SMS_MEMORY_STATUS for modem.

I'll fire another bug to provide the fix in gecko side for the problem of bug 891344.

Comment 18

[Bevis Tseng[:bevis][:btseng](Exited)]

No longer a 1.4+ blocking bug.
Check Bug 974820 instead.

Comment 19

[Ken Chang[:kenkai]]

Put this bug into backlog.

Comment 20

[BMO Automation]

Firefox OS is not being worked on