832341 - Black background in IE's test drive The Bayou

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Scoobidiver (away)]

After a few seconds, the background image becomes black.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/8a30e07815ff
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121214 Firefox/20.0 ID:20121214015122
Bad:
http://hg.mozilla.org/mozilla-central/rev/50d8f411d305
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121214 Firefox/20.0 ID:20121214072922
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8a30e07815ff&tochange=50d8f411d305


Regression window(m-c)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/66f91a854410
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121213 Firefox/20.0 ID:20121213140922
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/777fd91b7fda
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121213 Firefox/20.0 ID:20121213141630
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=66f91a854410&tochange=777fd91b7fda


In local build
Last Good: b80437be0e70
First Bad: afc699fc7e65
Triggered by:
afc699fc7e65	Matt Woodrow — Bug 820246 - Split nsDisplayCanvasBackground into separate color and image items. r=roc

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Don't adjust the border area

I *think* this is correct, fixes this test case.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why is this correct?

Comment 4

[Matt Woodrow (:mattwoodrow)]

When we call PaintBackground (from nsDisplayBackgroundImage::PaintInternal), we pass nsRect(offset, mFrame->GetSize()) as the aBorderArea parameter. The canvas area is passed as the dirty rect, and the clip rect.

Inside nsCSSRendering::PaintBackgroundWithSC, we pass the border area to PrepareBackgroundLayer.

nsCSSRendering::GetBackgroundLayerRect is also calling PrepareBackgroundLayer, so using the same value makes sense.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 706929 [details] [diff] [review]
Don't adjust the border area

Review of attachment 706929 [details] [diff] [review]:
-----------------------------------------------------------------

ok

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can you make a reftest for this?

Comment 7

[Matt Woodrow (:mattwoodrow)]

I can try, how do I get the 'CanvasArea()' to extend off the left of the screen?

Comment 8

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5cace63163

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a5cace63163

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #7)
> I can try, how do I get the 'CanvasArea()' to extend off the left of the
> screen?

Put it in an IFRAME?

Comment 11

[William Lachance (:wlach)]

I am not certain but I think this may have caused a regression (bug 837196)

Comment 12

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 706929 [details] [diff] [review]
Don't adjust the border area

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 820246
User impact if declined: Broken background on a fairly high profile site.
Testing completed (on m-c, etc.): Been on m-c for a few weeks
Risk to taking this patch (and alternatives if risky): Low risk. Requires bug 836844 to avoid regressions.
String or UUID changes made by this patch: None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f3b09048d33d

Comment 14

[Mihai Morar, (:MihaiMorar)]

Verified as Fixed on Windows 7 x64 using FF 20b5 and FF 21b6