836844 - CSS background is not painted correctly. The background is cut off by the height of the view.

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Alice0775 White]

Attachment: testcase html

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/20bbf73921f4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130131 Firefox/21.0 ID:20130131031009

Steps to reproduce:
1. Open attached testcase html
2. Scroll down

Actual results:
The background is cut off by the height of the view.

Expected results:
The background should be painted with whole height of page


Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/677e87c11252
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130129 Firefox/21.0 ID:20130129202850
Bad:
http://hg.mozilla.org/mozilla-central/rev/5f9775715519
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130130 Firefox/21.0 ID:20130130050547
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=677e87c11252&tochange=5f9775715519


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f8cdfa25ad9f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130129 Firefox/21.0 ID:20130129205947
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ab658aec6a28
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130129 Firefox/21.0 ID:20130129210748
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f8cdfa25ad9f&tochange=ab658aec6a28

Comment 1

[Alice0775 White]

Attachment: screenshot after scroll

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I reproduced this bug on Intel Mac OS X 10.8. (Firefox runs in x86-64.)

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Pass the right clip area for canvas frames

This matches what we do when painting, fixes this bug and the previous one.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 709443 [details] [diff] [review]
Pass the right clip area for canvas frames

Review of attachment 709443 [details] [diff] [review]:
-----------------------------------------------------------------

Need reftests!!!

Comment 10

[Matt Woodrow (:mattwoodrow)]

Attachment: Test

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/972c5c7d1ff0

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/972c5c7d1ff0

Comment 17

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 709443 [details] [diff] [review]
Pass the right clip area for canvas frames

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 832341 
User impact if declined: Only affects aurora if Bug 832341 is uplifted, but causes backgrounds to disappear when scrolling on some pages.
Testing completed (on m-c, etc.): Been on m-c for a while.
Risk to taking this patch (and alternatives if risky): Low risk.
String or UUID changes made by this patch: None

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 709443 [details] [diff] [review]
Pass the right clip area for canvas frames

Tracking and approving for uplift to go with 832341.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7d824075816

Comment 20

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20.b1:

Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 21

[Mihai Morar, (:MihaiMorar)]

I confirm this is fixed on FF 21b1 on Windows 7 x64, Mac OS 10.7 and Ubuntu 12.10.
Build id: (20130401192816)