832433 - Phones should use Android spinners

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

To have a UI that's simple (without Android's tabs) and scalable from a l10n perspective, it's better to use Spinners everywhere.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Use spinners on phones

This uses spinners on phones. On GB phones, this is emulated as a Button + PopupMenu.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Remove tabs widget

This removes the Android Tabs widget completely. Phew.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Remove tabs widget

This removes a redundant file on top of the previous patch.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 704021 [details] [diff] [review]
Part 2: Remove tabs widget

Nice! I feel better already with TabWidget gone.

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d919195cdf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea6e7fbcd3a5

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4d919195cdf0
https://hg.mozilla.org/mozilla-central/rev/ea6e7fbcd3a5

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 704016 [details] [diff] [review]
Part 1: Use spinners on phones

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: We show android style tabs on phones -- instead of spinners.
Testing completed (on m-c, etc.): Landed in m-c on 01/19
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 704021 [details] [diff] [review]
Part 2: Remove tabs widget

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: We show android style tabs on phones -- instead of spinners.
Testing completed (on m-c, etc.): Landed in m-c on 01/19
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Any reason this needs to skip the trains?  Seems like we'd be wise to let it ride the trains and keep an eye out for any regressions from such an overhaul.

Comment 10

[Sriram Ramasubramanian [:sriram]]

This is needed for the new Tabs UI changes in bug 817675. Most other patches that are needed have been uplifted.

(Note: This feature might even change as the UX is making calls on the UI still. But, to avoid problems in Aurora by missing a patch inbetween, I would like to uplift it and keep it in same state as m-c).

Comment 11

[Sriram Ramasubramanian [:sriram]]

The new design doesn't use spinners. We might not need to uplift this to Aurora. I could post a patch thats Aurora-ready (but I am not sure of the possible regressions as it would be double the work) or, we could uplift this and take the patch from m-c to be on top of this.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 704016 [details] [diff] [review]
Part 1: Use spinners on phones

Approving for Aurora but expecting that qa/mobile devs will keep an eye out for potential regressions once this gets to Beta and has more users.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c9cdc55bb1f
https://hg.mozilla.org/releases/mozilla-aurora/rev/a0a5f778473a