832487 - Update libpng to version 1.5.14

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Glenn Randers-Pehrson]

Libpng-1.5.14 is expected to be released on January 24th, 2013.  Right now it's at version 1.5.14rc03.  It would be good to test with rc03 to see if there are any problems, then land 1.5.14 after it's released.

Comment 1

[Glenn Randers-Pehrson]

Attachment: v00 update libpng to 1.5.14rc03

This is for testing only. Someone please run this through try-server

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I don't see any makefile changes here to actually build the new ARM code?

Comment 3

[Glenn Randers-Pehrson]

(In reply to Ryan VanderMeulen from comment #2)
> I don't see any makefile changes here to actually build the new ARM code?

There aren't.  We can revise the makefile/configure/mozpngconf.h whatever to
enable ARM support in bug #832390 once we know libpng-1.5.14 is OK.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=d3b055ff2ca6

Comment 5

[Max Stepin]

May I suggest a minor change in pngwutil.c (line 1049):

-      png_write_chunk_header(png_ptr, png_fdAT, 4 + length);
+      png_write_chunk_header(png_ptr, png_fdAT, (png_uint_32)(4 + length));


I see that's how it is used in other places:
png_write_chunk_header(png_ptr, png_PLTE, (png_uint_32)(num_pal * 3));
png_write_chunk_header(png_ptr, png_pCAL, (png_uint_32)total_len);
png_write_chunk_header(png_ptr, png_hIST, (png_uint_32)(num_hist * 2));

Comment 6

[Max Stepin]

I think png.c is missing from your patch, Glenn...

One more minor thing: last time we accidentally duplicated a comment in pngwrite.c 
It's the same comment at lines 317 and 323. We should remove the first one.

Comment 7

[Glenn Randers-Pehrson]

Attachment: v01 Update libpng to version 1.5.14

Fixed 3 things mentioned in comment#5 and comment#6, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

applying 832487
unable to find 'media/libpng/arm/arm_init.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/arm/arm_init.c.rej
unable to find 'media/libpng/arm/filter_neon.S' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/arm/filter_neon.S.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir

Looks like you lost the hg add in there.

Comment 9

[Glenn Randers-Pehrson]

Attachment: v02 Update libpng to version 1.5.14

Add arm directory with 2 files

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=170d1194c36f

Comment 11

[Glenn Randers-Pehrson]

Attachment: v03 Update libpng to version 1.5.14

patch for actual libpng-1.5.14, includes new apng.patch

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 705742 [details] [diff] [review]
v03 Update libpng to version 1.5.14

Looks good to me, thanks Glenn.

Comment 13

[Oleg Romashin (:romaxa)]

Attachment: Make arm neon stuff really compile..

probably it make sense to move it to another bug, but not sure

Comment 14

[Glenn Randers-Pehrson]

Yes, we already have another bug for the ARM NEON stuff. It's bug #832390 which is shown as a dependency of this bug.

Also, the "MOZ_" prefixes should be applied via macros in mozpngconf.h rather
than changing them in the code.

Comment 15

[Joe Drew (not getting mail)]

Comment on attachment 705742 [details] [diff] [review]
v03 Update libpng to version 1.5.14

Review of attachment 705742 [details] [diff] [review]:
-----------------------------------------------------------------

r=try

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51d02de3f48e

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/51d02de3f48e

Comment 18

[Glenn Randers-Pehrson]

Re comment #13: the ARM patch has been moved to bug #832390.