Update libpng to version 1.5.14

RESOLVED FIXED in mozilla21

Status

()

Core
Graphics
--
enhancement
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Glenn Randers-Pehrson, Assigned: Glenn Randers-Pehrson)

Tracking

unspecified
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

5 years ago
Libpng-1.5.14 is expected to be released on January 24th, 2013.  Right now it's at version 1.5.14rc03.  It would be good to test with rc03 to see if there are any problems, then land 1.5.14 after it's released.
(Assignee)

Updated

5 years ago
Depends on: 832390
(Assignee)

Updated

5 years ago
Blocks: 832390
No longer depends on: 832390
(Assignee)

Updated

5 years ago
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 704127 [details] [diff] [review]
v00 update libpng to 1.5.14rc03

This is for testing only. Someone please run this through try-server
I don't see any makefile changes here to actually build the new ARM code?
(Assignee)

Comment 3

5 years ago
(In reply to Ryan VanderMeulen from comment #2)
> I don't see any makefile changes here to actually build the new ARM code?

There aren't.  We can revise the makefile/configure/mozpngconf.h whatever to
enable ARM support in bug #832390 once we know libpng-1.5.14 is OK.

Comment 5

5 years ago
May I suggest a minor change in pngwutil.c (line 1049):

-      png_write_chunk_header(png_ptr, png_fdAT, 4 + length);
+      png_write_chunk_header(png_ptr, png_fdAT, (png_uint_32)(4 + length));


I see that's how it is used in other places:
png_write_chunk_header(png_ptr, png_PLTE, (png_uint_32)(num_pal * 3));
png_write_chunk_header(png_ptr, png_pCAL, (png_uint_32)total_len);
png_write_chunk_header(png_ptr, png_hIST, (png_uint_32)(num_hist * 2));

Comment 6

5 years ago
I think png.c is missing from your patch, Glenn...

One more minor thing: last time we accidentally duplicated a comment in pngwrite.c 
It's the same comment at lines 317 and 323. We should remove the first one.
(Assignee)

Comment 7

5 years ago
Created attachment 704266 [details] [diff] [review]
v01 Update libpng to version 1.5.14

Fixed 3 things mentioned in comment#5 and comment#6, thanks.
Attachment #704127 - Attachment is obsolete: true
applying 832487
unable to find 'media/libpng/arm/arm_init.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/arm/arm_init.c.rej
unable to find 'media/libpng/arm/filter_neon.S' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/arm/filter_neon.S.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir

Looks like you lost the hg add in there.
(Assignee)

Comment 9

5 years ago
Created attachment 704288 [details] [diff] [review]
v02 Update libpng to version 1.5.14

Add arm directory with 2 files
Attachment #704266 - Attachment is obsolete: true
(Assignee)

Comment 11

5 years ago
Created attachment 705742 [details] [diff] [review]
v03 Update libpng to version 1.5.14

patch for actual libpng-1.5.14, includes new apng.patch
Attachment #704288 - Attachment is obsolete: true
Comment on attachment 705742 [details] [diff] [review]
v03 Update libpng to version 1.5.14

Looks good to me, thanks Glenn.
Attachment #705742 - Flags: review?(joe)
Attachment #705742 - Flags: feedback+
Created attachment 706211 [details] [diff] [review]
Make arm neon stuff really compile..

probably it make sense to move it to another bug, but not sure
(Assignee)

Comment 14

5 years ago
Yes, we already have another bug for the ARM NEON stuff. It's bug #832390 which is shown as a dependency of this bug.

Also, the "MOZ_" prefixes should be applied via macros in mozpngconf.h rather
than changing them in the code.
Comment on attachment 705742 [details] [diff] [review]
v03 Update libpng to version 1.5.14

Review of attachment 705742 [details] [diff] [review]:
-----------------------------------------------------------------

r=try
Attachment #705742 - Flags: review?(joe) → review+
Keywords: checkin-needed
Attachment #706211 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/51d02de3f48e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
(Assignee)

Comment 18

5 years ago
Re comment #13: the ARM patch has been moved to bug #832390.
(Assignee)

Updated

5 years ago
Blocks: 841734
Depends on: 853190
No longer depends on: 853190
(Assignee)

Updated

5 years ago
No longer blocks: 841734
(Assignee)

Updated

5 years ago
No longer blocks: 832390
You need to log in before you can comment on or make changes to this bug.