Closed Bug 832848 Opened 7 years ago Closed 7 years ago

Remove tooltip code from PSM

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: Dolske, Assigned: briansmith)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached patch Patch v.0 (WIP) (obsolete) — Splinter Review
AFAICT, the tooltip related code in nsSecureBrowserUIImpl is entirely dead code -- nothing is actually consuming it. (And we were using it, it should be refactored, it's not doing anything terrible useful.)
Given patch 0, the following can also be removed (I see you noticed this too):

nsITransportSecurityInfo::shortSecurityDescription
TransportSecurityInfo::GetShortSecurityDescription(PRUnichar** aText)
TransportSecurityInfo::SetShortSecurityDescription(const PRUnichar* aText)
TransportSecurityInfo::mShortDesc
pipnss.properties: SignedBy
pippki.properties: SignedBy

mShortDesc gets serialize/deserialized into the cache. For backward compatibility:
TransportSecurityInfo::Write needs to write an empty string instead of mShortDesc.
TransportSecurityInfo::Read needs to read the string (which may not be empty) and ignore it.
The diff -w is easier to read because I had to change the indention in the change to nsNSSCallbacks.cpp.
Attachment #709436 - Flags: review?(dolske)
Assignee: nobody → bsmith
Attachment #709436 - Flags: review?(dolske) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c74ce1905b96
Blocks: 820887
Summary: Remove tooltip code from nsSecureBrowserUIImpl → Remove tooltip code from PSM
Target Milestone: --- → mozilla23
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4e7df5a393 - at least, so far, Linux and Mac agree that you shouldn't make TransportSecurityInfo::Write try to convert 'const char16_t*' to 'const PRUnichar*'.

https://tbpl.mozilla.org/php/getParsedLog.php?id=22804671&tree=Mozilla-Inbound if you like  your compiler errors Linux flavored, https://tbpl.mozilla.org/php/getParsedLog.php?id=22804979&tree=Mozilla-Inbound if you prefer Mac.
(In reply to Justin Dolske from comment #0)
> AFAICT, the tooltip related code in nsSecureBrowserUIImpl is entirely dead
> code -- nothing is actually consuming it.

http://hg.mozilla.org/comm-central/annotate/0c3935541187/suite/browser/nsBrowserStatusHandler.js#l383
I'll file a blocking bug on implementing the tooltip in UI code, as it seems as if it should be straightforward enough.
Depends on: 870710
No longer depends on: 870710
See Also: → 870710
(In reply to Phil Ringnalda (:philor) from comment #6)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4e7df5a393 - at
> least, so far, Linux and Mac agree that you shouldn't make
> TransportSecurityInfo::Write try to convert 'const char16_t*' to 'const
> PRUnichar*'.

Thanks.

Rebased and relanded with trivial fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/911f92728d22
Target Milestone: mozilla23 → mozilla24
https://hg.mozilla.org/mozilla-central/rev/911f92728d22
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.