832848 - Remove tooltip code from PSM

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.0 (WIP)

AFAICT, the tooltip related code in nsSecureBrowserUIImpl is entirely dead code -- nothing is actually consuming it. (And we were using it, it should be refactored, it's not doing anything terrible useful.)

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Given patch 0, the following can also be removed (I see you noticed this too):

nsITransportSecurityInfo::shortSecurityDescription
TransportSecurityInfo::GetShortSecurityDescription(PRUnichar** aText)
TransportSecurityInfo::SetShortSecurityDescription(const PRUnichar* aText)
TransportSecurityInfo::mShortDesc
pipnss.properties: SignedBy
pippki.properties: SignedBy

mShortDesc gets serialize/deserialized into the cache. For backward compatibility:
TransportSecurityInfo::Write needs to write an empty string instead of mShortDesc.
TransportSecurityInfo::Read needs to read the string (which may not be empty) and ignore it.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 1: Dolske's changes, rebased (must be folded with Brian's changes)

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 2: Brian's changes (must be folded with Dolske's changes)

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: diff -w version of attachment 709435 (Brian's changes) [NOT FOR CHECKIN]

The diff -w is easier to read because I had to change the indention in the change to nsNSSCallbacks.cpp.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c74ce1905b96

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4e7df5a393 - at least, so far, Linux and Mac agree that you shouldn't make TransportSecurityInfo::Write try to convert 'const char16_t*' to 'const PRUnichar*'.

https://tbpl.mozilla.org/php/getParsedLog.php?id=22804671&tree=Mozilla-Inbound if you like  your compiler errors Linux flavored, https://tbpl.mozilla.org/php/getParsedLog.php?id=22804979&tree=Mozilla-Inbound if you prefer Mac.

Comment 7

[[e-mail]]

(In reply to Justin Dolske from comment #0)
> AFAICT, the tooltip related code in nsSecureBrowserUIImpl is entirely dead
> code -- nothing is actually consuming it.

http://hg.mozilla.org/comm-central/annotate/0c3935541187/suite/browser/nsBrowserStatusHandler.js#l383

Comment 8

[[e-mail]]

I'll file a blocking bug on implementing the tooltip in UI code, as it seems as if it should be straightforward enough.

Comment 9

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Phil Ringnalda (:philor) from comment #6)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4e7df5a393 - at
> least, so far, Linux and Mac agree that you shouldn't make
> TransportSecurityInfo::Write try to convert 'const char16_t*' to 'const
> PRUnichar*'.

Thanks.

Rebased and relanded with trivial fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/911f92728d22

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/911f92728d22