Closed Bug 832950 Opened 8 years ago Closed 8 years ago

Consider removing frame annotations

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

bholley says he removed the last use of frame annotations in Gecko a while ago. Frame annotations complicate baseline compiler work, so it would be nice if we could remove them.

David, Luke, any thoughts on this, especially from a JSAPI point-of-view?
Fire ze missiles!  We've been wanting to do this forever (bug 546848).
(In reply to Luke Wagner [:luke] from comment #1)
> Fire ze missiles!  We've been wanting to do this forever (bug 546848).

Great! Taking.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Attachment #704590 - Flags: review?(luke)
Comment on attachment 704590 [details] [diff] [review]
Patch

r+ with prejudice (and with much love for bholley).
Attachment #704590 - Flags: review?(luke) → review+
(In reply to Luke Wagner [:luke] from comment #4)
> r+ with prejudice (and with much love for bholley).

<3
https://hg.mozilla.org/mozilla-central/rev/8116ecda192a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.