833004 - Can't start Tilt

Status: RESOLVED FIXED

(Firefox Graveyard :: Developer Tools: 3D View, defect, P1)

Description

[Paul Rouget [:paul]]

STR:
- open a new window
- start the inspector
- start tilt
- close the toolbox
- press ESC to stop tilt
- start the inspector
- see Tilt button being active (it should not)
- click on Tilt button
- Tilt doesn't start  (it should)

Comment 1

[Victor Porof [:vporof][:vp]]

Timestamp: 1/21/13 7:01:55 PM
Error: TypeError: this.inspector.selection is null
Source File: resource://gre/modules/devtools/TiltVisualizer.jsm
Line: 197

..when tilt is closed via ESC after closing the toolbox.

Comment 2

[Paul Rouget [:paul]]

cc'ing Optimizer, as I think it's related to how we handle the toggle state of the Tilt button.

Comment 3

[Girish Sharma [:Optimizer]]

I think that since the TiltVisualizer gave an exception, it does not restarts as the script has already exception-ed out.

The problem is basically that inspector.selecito is alredy gone by the time TileVisualizer tries to remove an event handler.

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Girish Sharma [:Optimizer] from comment #3)
> I think that since the TiltVisualizer gave an exception, it does not
> restarts as the script has already exception-ed out.
> 
> The problem is basically that inspector.selecito is alredy gone by the time
> TileVisualizer tries to remove an event handler.

Wanna fix it? :)

Comment 5

[Paul Rouget [:paul]]

This is pretty bad. We want to fix that in Firefox Aurora (firefox 20).

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1

Ok.

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 704892 [details] [diff] [review]
v1

Thank you Victor.

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/9225e25e3f1e

Comment 9

[Victor Porof [:vporof][:vp]]

Comment on attachment 704892 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Users won't be able to start the 3D view in some cases
User impact if declined: medium for developers, small for regular users
Testing completed (on m-c, etc.): fx-team
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/9225e25e3f1e

Comment 11

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bd00c6ae955e

Comment 12

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 13

[Ioana (away)]

Verified as fixed on Firefox 21 RC - 20130507015204.