833460 - saved ping files shouldn't be read in profile-after-change

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nathan Froyd [:froydnj]]

There are at least two things that can/should be done here:

1) Move reading ping files out of the main startup path.  Reading the files can be expensive, and there can be several of them, which only adds to hurt.
2) Make reading ping files async.

This bug is more about #1.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move reading saved pings to the timer-based callback

Just delay reading the pings until we hook everything up.  Individual pings
are already read async, so no need to tweak that.

Comment 2

[(dormant account)]

Comment on attachment 705052 [details] [diff] [review]
move reading saved pings to the timer-based callback

ok for short term fix. We should load them on the demand as we send them in the future.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a07bfe64ec

Comment 4

[David Mandelin [:dmandelin]]

Wow, that was amazingly fast. :-D How do you guys typically measure the effect of landing a startup patch like this?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f9a07bfe64ec