saved ping files shouldn't be read in profile-after-change

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

(Blocks 1 bug)

unspecified
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Telemetry:P1])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
There are at least two things that can/should be done here:

1) Move reading ping files out of the main startup path.  Reading the files can be expensive, and there can be several of them, which only adds to hurt.
2) Make reading ping files async.

This bug is more about #1.
Blocks: start-faster
Whiteboard: [Telemetry:P1] → [Telemetry:P1][
Whiteboard: [Telemetry:P1][ → [Telemetry:P1]
(Reporter)

Comment 1

6 years ago
Just delay reading the pings until we hook everything up.  Individual pings
are already read async, so no need to tweak that.
Attachment #705052 - Flags: review?(taras.mozilla)

Comment 2

6 years ago
Comment on attachment 705052 [details] [diff] [review]
move reading saved pings to the timer-based callback

ok for short term fix. We should load them on the demand as we send them in the future.
Attachment #705052 - Flags: review?(taras.mozilla) → review+
(Reporter)

Updated

6 years ago
Blocks: 833545
Wow, that was amazingly fast. :-D How do you guys typically measure the effect of landing a startup patch like this?
https://hg.mozilla.org/mozilla-central/rev/f9a07bfe64ec
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.