833619 - [Open_] Increase length of NCK code from 8 bytes up to 16 bytes

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[cyvins]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.52 Safari/537.17

Steps to reproduce:

1) load the system image with sim lock enabled
2) activate the sim lock function
3) boot up the device
4) input the unlocking pass code


Actual results:

Current SIM Lock implementation only supports 8 bytes unlocking passcode


Expected results:

It should support unlocking pass code more than 8 bytes, our lower sim-lock algorithm requires 16 bytes pass code

Comment 1

[Daniel Coloma:dcoloma]

Nominating as this blocks TEF certification.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Stealing.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

WIP patch
https://github.com/mozilla-b2g/gaia/pull/7796

I think I need to find a SIM card could accept 16 bytes PIN code to test, or needs QA help here.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7796

Patch here.
https://github.com/mozilla-b2g/gaia/pull/7796

The problem is we don't have a SIM card could accept more than 8 bytes to test.

Comment 5

[Beatriz Rodríguez [:brg]]

(In reply to Alive Kuo [:alive] from comment #4)
> The problem is we don't have a SIM card could accept more than 8 bytes to
> test.
This issue is not releated to SIM card PIN. This is the lenght of the Lock code for the device when you introduce a "wrong" SIM card that it is not the one of the supported carrier.
For testing this length, maybe we could need here the help of QC team or any OEM.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 706300 [details]
https://github.com/mozilla-b2g/gaia/pull/7796

Cancel review. I guess this bug is a hidden feature to me that I never knows we have wrong sim card alert dialog.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Beatriz Rodríguez [:brg] from comment #5)
> (In reply to Alive Kuo [:alive] from comment #4)
> > The problem is we don't have a SIM card could accept more than 8 bytes to
> > test.
> This issue is not releated to SIM card PIN. This is the lenght of the Lock
> code for the device when you introduce a "wrong" SIM card that it is not the
> one of the supported carrier.
> For testing this length, maybe we could need here the help of QC team or any
> OEM.

OK..So are you talking about NCK? It's not PIN for sure.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7801

Patch v1: Use the getAttribute instead of hard code.

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 706325 [details]
https://github.com/mozilla-b2g/gaia/pull/7801

Looks good and works fine.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Gaia Master
https://github.com/mozilla-b2g/gaia/commit/dc8ba5b755a11f98e181c3b7cf9718390c4ffb89

Comment 11

[Beatriz Rodríguez [:brg]]

(In reply to Alive Kuo [:alive] from comment #7)
> OK..So are you talking about NCK? It's not PIN for sure.

Yes, this is the length of NCK code. The previous development was done for 8bytes and one partner is asking for 16b support.

Comment 12

[Evelyn Hung]

Please update title to mean the real problem. I was totally misunderstanding the problem either, and did the same patch of attachment 706300 [details].
Thank Alive's help on this issue.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Marking this as status-b2g18-v1.0.0 fixed as well, just for clarity as we move forward with v1-train branches tracking/status.

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Vivien had done ;)

v1.0.0
https://github.com/mozilla-b2g/gaia/commit/6369dbf33b622faf4b4d176fed30b77c5c319dfc

v1-train
https://github.com/mozilla-b2g/gaia/commit/6369dbf33b622faf4b4d176fed30b77c5c319dfc

Comment 15

[Sam Shipley]

Issue doesn't reproduce on Unagi device:

Build ID: 20130214070203
December 5th Kernel
Gaia: 6544fdb8dddc56f1aefe94482402488c89eeec49
Gecko http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d1288313218e

16 bit passcode is programed and accepted successfully.