83377 - packages-mac out of synch, causing pkgcp.pl warnings

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[J.J. Enser]

pkgcp.pl is part of the release build packaging automation. It splits the files 
under mozilla/dist/viewer into separate installer modules, using the maniffest 
file located at:
mozilla/xpisntall/packager/packages-mac

(note that this perl script is xp and executed with each platform's respective 
packages-* file)

These packages-* files should be updated whenever files are obsoleted/moved to a 
different location. Today's warning list looks like this:

---

copy failed: viewer:Essential Files:oji.shlb (xpinstall:packager:packages-mac, 
43).
copy failed: viewer:Component Registry (xpinstall:packager:packages-mac, 49).
copy failed: viewer:Components:xuldoc.xpt (xpinstall:packager:packages-mac, 85).
copy failed: viewer:Components:xultmpl.xpt (xpinstall:packager:packages-mac, 86).
copy failed: viewer:Components:domds.xpt (xpinstall:packager:packages-mac, 104).
copy failed: viewer:Components:layout_base.xpt (xpinstall:packager:packages-mac, 
121).
copy failed: viewer:Components:layout_xul.xpt (xpinstall:packager:packages-mac, 
122).
copy failed: viewer:Components:layout_xul_outliner.xpt 
(xpinstall:packager:packages-mac, 123).
copy failed: viewer:Components:ucth.shlb (xpinstall:packager:packages-mac, 165).
copy failed: viewer:Components:exthandler.xpt (xpinstall:packager:packages-mac, 
176).
copy failed: viewer:Components:xpcom_xpti.xpt (xpinstall:packager:packages-mac, 
186).
copy failed: viewer:Components:signed.shlb (xpinstall:packager:packages-mac, 
319).

delete failed: Installer 
Modules:browser:viewer:chrome:comm:content:editor:EditorInitPage.html is not a 
file or directory (xpinstall:packager:packages-mac, browser, 222).
delete failed: Installer 
Modules:browser:viewer:chrome:comm:content:editor:EditorInitPagePlain.html is not 
a file or directory (xpinstall:packager:packages-mac, browser, 223).
delete failed: Installer Modules:browser:viewer:chrome:comm:content:editor:sb-
bookmarks-panel.xul is not a file or directory (xpinstall:packager:packages-mac, 
browser, 226).
delete failed: Installer Modules:browser:viewer:chrome:comm:content:editor:sb-
bookmarks.js is not a file or directory (xpinstall:packager:packages-mac, 
browser, 227).
delete failed: Installer Modules:browser:viewer:chrome:comm:content:editor:sb-
file-contextMenu.js is not a file or directory (xpinstall:packager:packages-mac, 
browser, 228).
delete failed: Installer Modules:browser:viewer:chrome:comm:content:editor:sb-
file-panel.js is not a file or directory (xpinstall:packager:packages-mac, 
browser, 229).
delete failed: Installer Modules:browser:viewer:chrome:comm:content:editor:sb-
file-panel.xul is not a file or directory (xpinstall:packager:packages-mac, 
browser, 230).
delete failed: Installer Modules:browser:viewer:chrome:comm:content:editor:sb-
FileWidgetFileHandler.js is not a file or directory (xpinstall:packager:packages-
mac, browser, 231).
delete failed: Installer 
Modules:browser:viewer:chrome:comm:content:communicator:domviewer is not a file 
or directory (xpinstall:packager:packages-mac, browser, 232).

---

the "copy fails" lines show references to non-existing files under dist/viewer
the "delete failed" lines show non-existing files in the target directory

Note that shared libraries appear in this list, which causes loss of 
functionality in the case of oji.shlb.
(I'm pretty sure that signed.shlb and ucth.shlb are obsolete and can be removed 
from packages-mac ... please confirm though)

I will need all the input I can get about any/all of the files listed in the log 
in order to bring packages-mac up to date since I am not familiar with all the 
product modules and/or required files.

Comment 1

[Jon Granrose]

0.9.2 - we need to get a handle on these warnings.

Comment 2

[J.J. Enser]

Attachment: 06/11 mac trunk build warnings (from pkgcp.pl)

Comment 3

[J.J. Enser]

I just posted today's warning list from pkgcp.pl in attachment #37938 [details].
If all the files listed there are effectively obsolete, the corresponding entries 
should be removed from packages-mac. I need module owners/engineers to review 
that list and confirm that they actually are no longer needed before I proceed.

Comment 4

[J.J. Enser]

Attachment: Proposed patch to both mozilla & netscape's packages-mac

Comment 5

[Simon Fraser [no longer active]]

I can't sr this, because I'm not sure that all the files that are being removed 
are really obsolete.

Ones I know are OK to remove:

-viewer:Essential Files:oji.shlb (became a component)
-viewer:Components:ucth.shlb (removed)
--viewer:chrome:comm:content:editor:EditorInitPage.html
--viewer:chrome:comm:content:editor:EditorInitPagePlain.html
--viewer:chrome:comm:content:editor:sb-bookmarks-panel.xul
--viewer:chrome:comm:content:editor:sb-bookmarks.js
--viewer:chrome:comm:content:editor:sb-file-contextMenu.js
--viewer:chrome:comm:content:editor:sb-file-panel.js
--viewer:chrome:comm:content:editor:sb-file-panel.xul
--viewer:chrome:comm:content:editor:sb-FileWidgetFileHandler.js
--viewer:chrome:comm:content:communicator:domviewer
-viewer:Essential Files:PSM.shlb
-viewer:psmdata:*
 -viewer:res:throbber
 -viewer:res:samples

Ones I don't know about:

-viewer:Components:xuldoc.xpt
-viewer:Components:xultmpl.xpt
-viewer:Components:domds.xpt
-viewer:Components:layout_base.xpt
-viewer:Components:layout_xul.xpt
-viewer:Components:layout_xul_outliner.xpt
-viewer:Components:exthandler.xpt
-viewer:Components:xpcom_xpti.xpt 
-viewer:Components:signed.shlb
-viewer:res:Mailnews:*
-viewer:defaults:profile:default-invite.rdf
-viewer:Chrome:autocomplete.xml
-viewer:Chrome:htmlBindings.xml
-viewer:Chrome:menulistBindings.xml
-viewer:Chrome:platformHTMLBindings.xml
-viewer:Chrome:radioBindings.xml
-viewer:Chrome:xul.css
-viewer:Chrome:xulBindings.xml

Comment 6

[J.J. Enser]

can other people on the cc list help determining which files are obsolete and 
which are not ?
If you think other people might know, please add them to the list.

Comment 7

[J.J. Enser]

signed.shlb is dead since May 4th. (see bug 75767)

1 down, 17 to go.

-viewer:Components:xuldoc.xpt
-viewer:Components:xultmpl.xpt
-viewer:Components:domds.xpt
-viewer:Components:layout_base.xpt
-viewer:Components:layout_xul.xpt
-viewer:Components:layout_xul_outliner.xpt
-viewer:Components:exthandler.xpt
-viewer:Components:xpcom_xpti.xpt 
-viewer:res:Mailnews:*
-viewer:defaults:profile:default-invite.rdf
-viewer:Chrome:autocomplete.xml
-viewer:Chrome:htmlBindings.xml
-viewer:Chrome:menulistBindings.xml
-viewer:Chrome:platformHTMLBindings.xml
-viewer:Chrome:radioBindings.xml
-viewer:Chrome:xul.css
-viewer:Chrome:xulBindings.xml

Comment 8

[Jean-Francois Ducarroz]

viewer:res:Mailnews:* is obsolete since a very very long time!

Comment 9

[J.J. Enser]

I would like to check this in today. If no additional input regarding the .xpt  
and .xml files, I need a= for the reviewd lines:

-viewer:Essential Files:oji.shlb (became a component)
-viewer:Components:ucth.shlb (removed)
-viewer:chrome:comm:content:editor:EditorInitPage.html
-viewer:chrome:comm:content:editor:EditorInitPagePlain.html
-viewer:chrome:comm:content:editor:sb-bookmarks-panel.xul
-viewer:chrome:comm:content:editor:sb-bookmarks.js
-viewer:chrome:comm:content:editor:sb-file-contextMenu.js
-viewer:chrome:comm:content:editor:sb-file-panel.js
-viewer:chrome:comm:content:editor:sb-file-panel.xul
-viewer:chrome:comm:content:editor:sb-FileWidgetFileHandler.js
-viewer:chrome:comm:content:communicator:domviewer
-viewer:Essential Files:PSM.shlb
-viewer:psmdata:*
-viewer:res:throbber
-viewer:res:samples
-viewer:Components:signed.shlb
-viewer:res:Mailnews:*

Anybody?

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 11

[J.J. Enser]

fixed both mozilla and ns packages-mac to removed obsolete files

Comment 12

[Jon Granrose]

verified.

Comment 13

[Kathleen :Brade]

reopening bug per a bugscape bug
when this fix was checked in, :viewer:Components:oji.shlb was not added so the 
OJI library isn't being installed on Macintosh.  We need to fix this.

Comment 14

[J.J. Enser]

I don't think we need to have both bugs open.
Since we have a specific bug about oji being missing for OS9 installer & OSX
disk image (bugscape bug #10608), upcoming patch to ake care of it will be
submitted there.
closing again.

Comment 15

[Jon Granrose]

verified again.