833931 - Fix unused-result build warnings in OfflineCacheUpdateParent.cpp (a.k.a. land the not-yet-fixed warning-fixing/silencing parts of bug 736501's patches)

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 736501's patches
 (a) fixed/silenced a bunch of unused-result warnings.
 (b) upgraded unused-result warnings to be fatal.

The patches were backed out because (b) caused build errors on some configurations (due to unused-result warnings in jemalloc).

I'm not sure what the status (or possibility of re-landing) part (b) is, but we can & should re-land part (a) to clean up the existing unused-result warnings. (regardless of whether we make them fatal)

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> Bug 736501's patches
(sorry, s/patches/patch/)

So, that patch for Bug 736501 (which was backed out) is:
 https://hg.mozilla.org/mozilla-central/rev/6a7bfd84596e

Of the changes in that patch, most have actually been fixed independently elsewhere:
 - the ContentParent chunk was fixed in Bug 745148 part 3.
      https://hg.mozilla.org/mozilla-central/rev/71300529a740
 - the PluginInstanceParent chunk was fixed in Bug 780489.
      https://hg.mozilla.org/mozilla-central/rev/533e0681e6ff
 - the nsTestCrasher chunk was later fixed in Bug 755050.
      https://hg.mozilla.org/mozilla-central/rev/061b5c0c5580

Only the OfflineCacheUpdateParent.cpp issues remain.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

This is essentially just the final chunk of
 https://hg.mozilla.org/mozilla-central/rev/6a7bfd84596e#l6.2
un-bitrotted and applied to trunk.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63c006191d08

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63c006191d08