Fix unused-result build warnings in OfflineCacheUpdateParent.cpp (a.k.a. land the not-yet-fixed warning-fixing/silencing parts of bug 736501's patches)

RESOLVED FIXED in mozilla21

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla21
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 736501's patches
 (a) fixed/silenced a bunch of unused-result warnings.
 (b) upgraded unused-result warnings to be fatal.

The patches were backed out because (b) caused build errors on some configurations (due to unused-result warnings in jemalloc).

I'm not sure what the status (or possibility of re-landing) part (b) is, but we can & should re-land part (a) to clean up the existing unused-result warnings. (regardless of whether we make them fatal)
(Assignee)

Updated

6 years ago
Blocks: 736501
(Assignee)

Comment 1

6 years ago
(In reply to Daniel Holbert [:dholbert] from comment #0)
> Bug 736501's patches
(sorry, s/patches/patch/)

So, that patch for Bug 736501 (which was backed out) is:
 https://hg.mozilla.org/mozilla-central/rev/6a7bfd84596e

Of the changes in that patch, most have actually been fixed independently elsewhere:
 - the ContentParent chunk was fixed in Bug 745148 part 3.
      https://hg.mozilla.org/mozilla-central/rev/71300529a740
 - the PluginInstanceParent chunk was fixed in Bug 780489.
      https://hg.mozilla.org/mozilla-central/rev/533e0681e6ff
 - the nsTestCrasher chunk was later fixed in Bug 755050.
      https://hg.mozilla.org/mozilla-central/rev/061b5c0c5580

Only the OfflineCacheUpdateParent.cpp issues remain.
(Assignee)

Updated

6 years ago
Summary: Land the warning-fixing/silencing parts of bug 736501's patches → Land the not-yet-fixed warning-fixing/silencing parts of bug 736501's patches
(Assignee)

Updated

6 years ago
Summary: Land the not-yet-fixed warning-fixing/silencing parts of bug 736501's patches → Fix unused-result build warnings in OfflineCacheUpdateParent.cpp (a.k.a. land the not-yet-fixed warning-fixing/silencing parts of bug 736501's patches)
(Assignee)

Comment 2

6 years ago
Created attachment 705494 [details] [diff] [review]
fix

This is essentially just the final chunk of
 https://hg.mozilla.org/mozilla-central/rev/6a7bfd84596e#l6.2
un-bitrotted and applied to trunk.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #705494 - Flags: review?(honzab.moz)
Attachment #705494 - Flags: review?(honzab.moz) → review+
(Assignee)

Updated

6 years ago
Blocks: 834054
https://hg.mozilla.org/mozilla-central/rev/63c006191d08
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.