834054 - Mark 'uriloader' subdirs w/ c++ files as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Daniel Holbert [:dholbert]]

With bug 833931 fixed, the mozilla-central "prefetch" subdirectory is entirely build-warning-free on my machine. Filing this bug on marking it (& its subdirectories that have C++ files) as FAIL_ON_WARNINGS.

Comment 1

[Daniel Holbert [:dholbert]]

Sorry, I meant the 'uriloader' directory (which includes /uriloader/prefetch)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 705616 [details] [diff] [review]
fix

Review of attachment 705616 [details] [diff] [review]:
-----------------------------------------------------------------

Go for it!

Comment 4

[Daniel Holbert [:dholbert]]

I hit a build warning in android-only code, in my first try push:
  https://tbpl.mozilla.org/?tree=Try&rev=42fc20026593
So, I filed bug 834072 w/ a fix, and did another Try push w/ that included:
 https://tbpl.mozilla.org/?tree=Try&rev=fd3e3a8dbd3f

Assuming that's green (and bug 834072 gets r+), we should be able to land this.

Comment 5

[Daniel Holbert [:dholbert]]

Green try run (w/ updated fix for bug 834072):
  https://tbpl.mozilla.org/?tree=Try&rev=925b9b36e62f

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/33994a9160d6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/33994a9160d6