833942 - Add "remove" to about:home topsites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

After talking to ian this morning, I realized this should be fairly simple. Accoding to his specs:

http://cl.ly/image/3U2v2c1O0Z3G/o

"Replace pinned site with a blank thumbnail. user can either ad a site to this spot, or see it replaced with an awesomebar result the next time they return to about:home. Remove behaves the same as in the Awesomescreen -- the item is removed from history."

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch v1

I hijacked the unpinSite function to do this because some/most of the logic is duplicated. If you have better naming or api ideas, I'd be happy to hear.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 705503 [details] [diff] [review]
Patch v1

>diff --git a/mobile/android/base/AboutHomeContent.java b/mobile/android/base/AboutHomeContent.java

>+    public static enum UnpinFlags {
>+        REMOVE_HISTORY

Let's add REMOVE_PIN here too, so it's a complete set of flags


>+    public void unpinSite(final UnpinFlags removeFromHistory) {

removeFromHistory -> flags

>diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java

>             case R.id.abouthome_topsites_unpin:
>-                mAboutHomeContent.unpinSite();
>+                mAboutHomeContent.unpinSite(null);

                  mAboutHomeContent.unpinSite(AboutHomeContent.UnpinFlags.REMOVE_PIN);


r+ with those nits fixed. I can make the changes and land it

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d612985bf5ca

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d612985bf5ca

Comment 5

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-10)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.2