847083 - java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent.unpinSite(AboutHomeContent.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 22.0a1/20120302: bp-6aceeb79-983c-492f-a892-c4d3d2130302.

java.lang.NullPointerException
	at org.mozilla.gecko.AboutHomeContent.unpinSite(AboutHomeContent.java:990)
	at org.mozilla.gecko.BrowserApp.onContextItemSelected(BrowserApp.java:1106)
	at android.app.Activity.onMenuItemSelected(Activity.java:2209)
	at com.android.internal.policy.impl.PhoneWindow$ContextMenuCallback.onMenuItemSelected(PhoneWindow.java:2889)
	at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:143)
	at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:860)
	at com.android.internal.view.menu.MenuDialogHelper.onClick(MenuDialogHelper.java:141)
	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:900)
	at android.widget.AdapterView.performItemClick(AdapterView.java:284)
	at android.widget.ListView.performItemClick(ListView.java:3736)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:1975)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3687)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:625)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.AboutHomeContent.unpinSite%28AboutHomeContent.java%29

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Forgot to add this to the list. When we create the input element we check if it matches any known ones. For DateTime that involves checking against a list. If we fail to find a match we crash.

I wonder if we should do something more graceful if we get invalid data here. For instance, I know on pre-ICS devices we just don't show a dialog in some cases. But crashing was nice in this case :)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't have any better suggestions right now. Maybe if we get more issues we'll be forced to re-think the way it works. Until then, this seems fine.

Comment 3

[Wesley Johnston (:wesj)]

Grr. I landed this with the wrong bug #:
https://hg.mozilla.org/releases/mozilla-aurora/rev/3fdb05a3cba2