java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent.unpinSite(AboutHomeContent.java)

RESOLVED FIXED in Firefox 26

Status

()

Firefox for Android
General
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Scoobidiver (away), Assigned: wesj)

Tracking

({crash, regression})

20 Branch
Firefox 26
ARM
Android
crash, regression
Points:
---

Firefox Tracking Flags

(firefox19 unaffected, firefox20 affected, firefox21 affected, firefox26 fixed)

Details

(Whiteboard: [native-crash], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
There's one crash in 22.0a1/20120302: bp-6aceeb79-983c-492f-a892-c4d3d2130302.

java.lang.NullPointerException
	at org.mozilla.gecko.AboutHomeContent.unpinSite(AboutHomeContent.java:990)
	at org.mozilla.gecko.BrowserApp.onContextItemSelected(BrowserApp.java:1106)
	at android.app.Activity.onMenuItemSelected(Activity.java:2209)
	at com.android.internal.policy.impl.PhoneWindow$ContextMenuCallback.onMenuItemSelected(PhoneWindow.java:2889)
	at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:143)
	at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:860)
	at com.android.internal.view.menu.MenuDialogHelper.onClick(MenuDialogHelper.java:141)
	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:900)
	at android.widget.AdapterView.performItemClick(AdapterView.java:284)
	at android.widget.ListView.performItemClick(ListView.java:3736)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:1975)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3687)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:625)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.AboutHomeContent.unpinSite%28AboutHomeContent.java%29
Assignee: nobody → wjohnston
(Reporter)

Updated

5 years ago
Blocks: 833942
status-firefox21: --- → affected
Keywords: regression
Version: Trunk → Firefox 21
(Reporter)

Updated

5 years ago
No longer blocks: 833942
status-firefox19: --- → unaffected
status-firefox20: --- → affected
Version: Firefox 21 → Firefox 20
(Reporter)

Updated

5 years ago
See Also: → bug 860320
(Reporter)

Updated

5 years ago
See Also: → bug 860323
(Reporter)

Updated

5 years ago
status-firefox22: affected → ---
(Assignee)

Comment 1

5 years ago
Created attachment 794949 [details] [diff] [review]
Patch

Forgot to add this to the list. When we create the input element we check if it matches any known ones. For DateTime that involves checking against a list. If we fail to find a match we crash.

I wonder if we should do something more graceful if we get invalid data here. For instance, I know on pre-ICS devices we just don't show a dialog in some cases. But crashing was nice in this case :)
Attachment #794949 - Flags: review?(mark.finkle)
Attachment #794949 - Flags: review?(mark.finkle) → review+
I don't have any better suggestions right now. Maybe if we get more issues we'll be forced to re-think the way it works. Until then, this seems fine.
(Assignee)

Comment 3

5 years ago
Grr. I landed this with the wrong bug #:
https://hg.mozilla.org/releases/mozilla-aurora/rev/3fdb05a3cba2
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox26: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.