Last Comment Bug 833949 - convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray
: convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to ns...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 21.0
Assigned To: :aceman
:
Mentors:
http://mxr.mozilla.org/comm-central/i...
Depends on:
Blocks: 394167
  Show dependency treegraph
 
Reported: 2013-01-23 12:56 PST by :aceman
Modified: 2013-01-26 09:53 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.02 KB, patch)
2013-01-23 13:39 PST, :aceman
neil: review+
Details | Diff | Splinter Review
patch v2 (3.48 KB, patch)
2013-01-25 12:08 PST, :aceman
neil: review+
Details | Diff | Splinter Review

Description :aceman 2013-01-23 12:56:09 PST
Defined as a variable in:

    mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
        line 738 -- m_cachedMemCacheEntries->AppendElement(cacheEntrySupports);
        line 750 -- m_cachedMemCacheEntries->RemoveElement(cacheEntrySupports); 
    mailnews/base/util/nsMsgMailNewsUrl.h (View Hg log or Hg annotations)
        line 60 -- nsCOMPtr<nsISupportsArray> m_cachedMemCacheEntries; 

Referenced in:

    mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
        line 732 -- if (!m_cachedMemCacheEntries)
        line 733 -- NS_NewISupportsArray(getter_AddRefs(m_cachedMemCacheEntries));
        line 734 -- if (m_cachedMemCacheEntries)
        line 746 -- if (m_cachedMemCacheEntries)
Comment 1 :aceman 2013-01-23 13:39:27 PST
Created attachment 705536 [details] [diff] [review]
patch
Comment 2 neil@parkwaycc.co.uk 2013-01-24 04:51:57 PST
Comment on attachment 705536 [details] [diff] [review]
patch

It's OK but I'd have preferred an nsCOMArray.
Comment 3 :aceman 2013-01-24 05:21:46 PST
Why? Isn't nsTArray more strict?
Comment 4 :aceman 2013-01-25 12:08:10 PST
Created attachment 706527 [details] [diff] [review]
patch v2
Comment 5 neil@parkwaycc.co.uk 2013-01-25 13:38:25 PST
Comment on attachment 706527 [details] [diff] [review]
patch v2

nsCOMArray can do things that nsTArray can't and uses less code. However it does have a weird API, and I'm still waiting on review to fix that :-(
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-01-26 09:53:13 PST
https://hg.mozilla.org/comm-central/rev/cb616b4ba9b4

Note You need to log in before you can comment on or make changes to this bug.