convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray

RESOLVED FIXED in Thunderbird 21.0

Status

MailNews Core
Backend
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 21.0

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

3.48 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Defined as a variable in:

    mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
        line 738 -- m_cachedMemCacheEntries->AppendElement(cacheEntrySupports);
        line 750 -- m_cachedMemCacheEntries->RemoveElement(cacheEntrySupports); 
    mailnews/base/util/nsMsgMailNewsUrl.h (View Hg log or Hg annotations)
        line 60 -- nsCOMPtr<nsISupportsArray> m_cachedMemCacheEntries; 

Referenced in:

    mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
        line 732 -- if (!m_cachedMemCacheEntries)
        line 733 -- NS_NewISupportsArray(getter_AddRefs(m_cachedMemCacheEntries));
        line 734 -- if (m_cachedMemCacheEntries)
        line 746 -- if (m_cachedMemCacheEntries)
(Assignee)

Comment 1

4 years ago
Created attachment 705536 [details] [diff] [review]
patch
Attachment #705536 - Flags: review?(neil)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED

Comment 2

4 years ago
Comment on attachment 705536 [details] [diff] [review]
patch

It's OK but I'd have preferred an nsCOMArray.
Attachment #705536 - Flags: review?(neil) → review+
(Assignee)

Comment 3

4 years ago
Why? Isn't nsTArray more strict?
(Assignee)

Comment 4

4 years ago
Created attachment 706527 [details] [diff] [review]
patch v2
Attachment #705536 - Attachment is obsolete: true
Attachment #706527 - Flags: review?(neil)

Comment 5

4 years ago
Comment on attachment 706527 [details] [diff] [review]
patch v2

nsCOMArray can do things that nsTArray can't and uses less code. However it does have a weird API, and I'm still waiting on review to fix that :-(
Attachment #706527 - Flags: review?(neil) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Summary: convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsTArray → convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray
https://hg.mozilla.org/comm-central/rev/cb616b4ba9b4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in before you can comment on or make changes to this bug.