Closed Bug 833949 Opened 7 years ago Closed 7 years ago
Msg Mail News Url::m _cached Mem Cache Entries from ns ISupports Array to ns COMArray
Defined as a variable in: mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations) line 738 -- m_cachedMemCacheEntries->AppendElement(cacheEntrySupports); line 750 -- m_cachedMemCacheEntries->RemoveElement(cacheEntrySupports); mailnews/base/util/nsMsgMailNewsUrl.h (View Hg log or Hg annotations) line 60 -- nsCOMPtr<nsISupportsArray> m_cachedMemCacheEntries; Referenced in: mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations) line 732 -- if (!m_cachedMemCacheEntries) line 733 -- NS_NewISupportsArray(getter_AddRefs(m_cachedMemCacheEntries)); line 734 -- if (m_cachedMemCacheEntries) line 746 -- if (m_cachedMemCacheEntries)
Comment on attachment 705536 [details] [diff] [review] patch It's OK but I'd have preferred an nsCOMArray.
Attachment #705536 - Flags: review?(neil) → review+
Why? Isn't nsTArray more strict?
Comment on attachment 706527 [details] [diff] [review] patch v2 nsCOMArray can do things that nsTArray can't and uses less code. However it does have a weird API, and I'm still waiting on review to fix that :-(
Attachment #706527 - Flags: review?(neil) → review+
Summary: convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsTArray → convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in before you can comment on or make changes to this bug.