833988 - Convert nsMsgCompose::BuildMailListArray nsISupportsArray argument to something better

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[:aceman]

nsresult nsMsgCompose::BuildMailListArray(nsIAbDirectory* parentDir,
                                          nsISupportsArray* array)

and

nsresult nsMsgCompose::GetMailListAddresses(nsString& name, nsISupportsArray* mailListArray, nsIMutableArray** addressesArray)

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 705567 [details] [diff] [review]
patch

Review of attachment 705567 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok afaikt.

Comment 3

[[e-mail]]

Comment on attachment 705567 [details] [diff] [review]
patch

>       nsMsgMailList* mailList;
>-      rv = enumerator->CurrentItem((nsISupports**)&mailList);
>+      rv = enumerator->GetNext((nsISupports**)&mailList);
I'm sorry but I can't perpetuate this horror, the code needs a rewrite.

Comment 4

[[e-mail]]

Attachment: Proposed patch

* Moved more of the fullname init code into the constructor
* Changed the array from an nsISupportsArray to an nsTArray
* Rewrote GetMailListAddresses to use an IndexOf comparator

Comment 5

[:aceman]

Quite involved rewrite, even the class changed to struct :)

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 705819 [details] [diff] [review]
Proposed patch

Review of attachment 705819 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and the unit tests pass :-)

Comment 7

[[e-mail]]

Pushed comm-central changeset c52e29d0ff20.