Closed Bug 834082 Opened 9 years ago Closed 9 years ago

[Lint] Move PNG files to drawable-mdpi folder

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(1 file, 1 obsolete file)

Android lint complains if the png files are in drawable/ folder instead of drawable-mdpi/ folder. It's better to move them to drawable-mdpi/ folder.
Attached patch Patch (obsolete) — Splinter Review
Patch for moving aaaaall PNG files.
Attachment #705658 - Flags: review?(bnicholson)
Attached patch PatchSplinter Review
Added few more changes.
Attachment #705658 - Attachment is obsolete: true
Attachment #705658 - Flags: review?(bnicholson)
Attachment #705959 - Flags: review?(bnicholson)
Depends on: 834376
Comment on attachment 705959 [details] [diff] [review]
Patch

Review of attachment 705959 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/Makefile.in
@@ +1060,5 @@
>  JAVA_CLASSPATH = $(ANDROID_SDK)/android.jar
>  
>  ifdef MOZ_CRASHREPORTER
>  FENNEC_PP_JAVA_FILES += CrashReporter.java
> +RES_DRAWABLE_MDPI += mobile/android/base/resources/drawable-mdpi/crash_reporter.png

This should be res/drawable-mdpi/crash_reporter.png
Attachment #705959 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/ec601ae4a64d
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Depends on: 1040443
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.