834082 - [Lint] Move PNG files to drawable-mdpi folder

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Android lint complains if the png files are in drawable/ folder instead of drawable-mdpi/ folder. It's better to move them to drawable-mdpi/ folder.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Patch for moving aaaaall PNG files.

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://tbpl.mozilla.org/?tree=Try&rev=bc1d18d270cc

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Added few more changes.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 705959 [details] [diff] [review]
Patch

Review of attachment 705959 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/Makefile.in
@@ +1060,5 @@
>  JAVA_CLASSPATH = $(ANDROID_SDK)/android.jar
>  
>  ifdef MOZ_CRASHREPORTER
>  FENNEC_PP_JAVA_FILES += CrashReporter.java
> +RES_DRAWABLE_MDPI += mobile/android/base/resources/drawable-mdpi/crash_reporter.png

This should be res/drawable-mdpi/crash_reporter.png

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec601ae4a64d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ec601ae4a64d