Closed
Bug 834082
Opened 12 years ago
Closed 12 years ago
[Lint] Move PNG files to drawable-mdpi folder
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(1 file, 1 obsolete file)
|
48.70 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
Android lint complains if the png files are in drawable/ folder instead of drawable-mdpi/ folder. It's better to move them to drawable-mdpi/ folder.
|
Assignee | |
Comment 1•12 years ago
|
||
Patch for moving aaaaall PNG files.
Attachment #705658 -
Flags: review?(bnicholson)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Comment 3•12 years ago
|
||
Added few more changes.
Attachment #705658 -
Attachment is obsolete: true
Attachment #705658 -
Flags: review?(bnicholson)
Attachment #705959 -
Flags: review?(bnicholson)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 705959 [details] [diff] [review]
Patch
Review of attachment 705959 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/Makefile.in
@@ +1060,5 @@
> JAVA_CLASSPATH = $(ANDROID_SDK)/android.jar
>
> ifdef MOZ_CRASHREPORTER
> FENNEC_PP_JAVA_FILES += CrashReporter.java
> +RES_DRAWABLE_MDPI += mobile/android/base/resources/drawable-mdpi/crash_reporter.png
This should be res/drawable-mdpi/crash_reporter.png
Attachment #705959 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•