834084 - [Settings][UX] Incorrect screen layer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : Incorrect screen layer
2. Precondition : SIM lock
3. Tester's Action : Idle - notification bar down - Airplane mode on - Airplane mode off
4. Detailed Symptom (ENG.) : Screen layer order: PIN code - notification - keypad.
After typing PIN code, user can't ok button of PIN code screen. It's abnormal case.
6. Expected : plz check screen order
7. Reproducibility: Y
1)Frequency Rate : 100%
8. Gaia revision : 7b8dea7e7ec377a2143151bbe5e9998d87f7b36d

Comment 1

[Leo]

Attachment: Add a screenchot

Add a screenshot

Comment 2

[Dietrich Ayala (:dietrich)]

Very narrow case with little possibility that user will encounter. Blocking-, tracking+.

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Hi Dietrich, there is a high possibility of this happening in the following use case scenario: 

Turn on airplane mode (i.e. for taking a flight) -> Turn off airplane mode from notification bar "plane button" (i.e. when arriving at destination):

Expected: Enter SIM PIN screen should be on top of everything else
Actual: The notifications screen (i.e. bar pulled down) sits between the enter SIM PIN screen and the keypad, overlapping the "OK" button to confirm the PIN.

Comment 4

[Dietrich Ayala (:dietrich)]

Thanks Mihai. That use-case is itself not going to be very common.

Please note that tracking-b2g18+ means we would *really* like a fix for this, just will not hold the release back for only this issue.

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for the clarifications Dietrich, I will have a look at fixing it :)

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #8872 - Hide utility-tray when simpin-dialog is shown

Add rule to zindex.css for simpin-dialog to promote the dialog-overlay to the same level as the utility-bar and update/fix comment styling and typos.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 730723 [details]
Pull Request #8872 - Hide utility-tray when simpin-dialog is shown

I think it will be a lot safer to just call |UtilityTray.hide()| when showing the sim pin dialog, adding extra edge cases to zindex.css doesn't feel right.

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Hi Etienne, thanks for the feedback! I updated the commit with your suggestion. 

I was also initially looking at a pure JS way to solve it but I thought simply calling methods from other modules (or firing events) would break the modularity of those respective apps/classes. Now I see this is also used in other places like cards_view, notifications, etc. :)

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 730723 [details]
Pull Request #8872 - Hide utility-tray when simpin-dialog is shown

Thanks!

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Merged to master by Etienne, commit:
https://github.com/mozilla-b2g/gaia/commit/4353d780f1393182be49b83d40a7ca7cfeea424d

Etienne, can you close the bug? I can't seem to be able to set RESOLVED>FIXED.

Comment 11

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 730723 [details]
Pull Request #8872 - Hide utility-tray when simpin-dialog is shown

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): SIM PIN dialog
User impact if declined: High (bug noticeable when toggling airplane mode)
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low/None
String or UUID changes made by this patch: No

Comment 12

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/4353d780f1393182be49b83d40a7ca7cfeea424d

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 4353d780f1393182be49b83d40a7ca7cfeea424d as:
v1-train: a7a0ed8751dbe359d1d1373665cf95db2b780565