834114 - [OPEN_][WIFI] Unable to connect to the access point through obtaining the AP WPS PIN.(617001980100)

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Wifi, defect)

Description

[Firefox_Mozilla]

Steps to reproduce:
1 Select the access point that supports WPS AP;
2 Select a way to connect;

Expected results:
we can choice kinds of way to connect this AP according the AP settings.

Actual results:
when selecting "AP PIN  connection"in wifi settings of firefox phone and entering the right PIN, it also can not be unable to connect to this access point.

Comment 1

[Kai-Chih Hu [:khu]]

We will take a look on this case.

Comment 2

[Michael Vines [:m1] [:evilmachines]]

(tef+, assuming this is still an issue)

Comment 3

[Vincent Chang[:vchang][changyihsin]]

I can't reproduce the problem last weeks with ASUS wifi router. I'll try to reproduce the problem tomorrow. Not sure if it's a kind of IOT issue with different wifi AP.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

I was able to reproduce this with a Cisco Linksys E4200 Router

logcat is attached.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Screenshot showing WPS trying to connect.  It doesn't seem to detect the name even.  BlackSabbath is the wps in mix mode security of wpa2/wpa.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/a56593f84577
Gaia   69cfb9f7d00e5ee7886e40645240686091b6b57e
BuildID 20130311095652
Version 18.0
Unagi

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Hi Naoki, 

Thanks for your help. I can reproduce the bug now. Will try to post a new patch soon. 

Hi Michael,  

I don't found any of iPhone/HTC/Galaxy S2 support AP pin feature. Do we really need  to block on this ? I believe that wps push button and enrollee pin are good enough for the time being.

Comment 8

[Vincent Chang[:vchang][changyihsin]]

Attachment: Possible fix, patch v1.0

wpa_supplicant supports "my pin" and "ap pin" functions. The commands are listed below. 
my pin: 
wps_pin <BSSID> [PIN]

ap pin: 
wps_reg <BSSID> <AP PIN>

For "my pin" function, <BSSID> can accept keyword "any" and generate the pin value. The generated pin can be filled in the access point. 

However, for "ap pin" function, we can't use keyword "any" for <BSSID>, and have to specify the access point's BSSID(00:50:ba:48:88:88 for instance) and pin code generated by access point. 

Once the patch is laned, we still need GAIA's help to add a new inputbox to enter bssid. Not sure if it is user friendly UX design ?

Comment 9

[Michael Vines [:m1] [:evilmachines]]

(In reply to Vincent Chang[:vchang] from comment #7)
> Hi Michael,  
> 
> I don't found any of iPhone/HTC/Galaxy S2 support AP pin feature. Do we
> really need  to block on this ? I believe that wps push button and enrollee
> pin are good enough for the time being.

That sounds fair to me.   Firefox_Mozilla -- please let us know if you disagree, and if so why.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Hey Vincent, how does this patch fit in with bug 791506 (and the related bug 790231)? I also wonder if it wouldn't be worth having Masashi take a look at your patch here, since he understand WPS better than I do.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 725426 [details] [diff] [review]
Possible fix, patch v1.0

Clearing this request pending an answer to comment 10.

Comment 12

[Vincent Chang[:vchang][changyihsin]]

(In reply to Blake Kaplan (:mrbkap) from comment #10)
> Hey Vincent, how does this patch fit in with bug 791506 (and the related bug
> 790231)? I also wonder if it wouldn't be worth having Masashi take a look at
> your patch here, since he understand WPS better than I do.

Hey Blake, thanks for your reminding. I'll redirect the review to Masashi.

Comment 13

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 725426 [details] [diff] [review]
Possible fix, patch v1.0

Hey Masashi, if my understand correct, we should use "wps_reg <bssid> <pin>" to support AP pin function instead of "wps_pin". 

Here is the reference page. 
http://svn0.us-east.freebsd.org/base/vendor/wpa/0.6.10/wpa_supplicant/README-WPS

Comment 14

[Masashi Honma]

> I don't found any of iPhone/HTC/Galaxy S2 support AP pin feature.
> Do we really need  to block on this ?
> I believe that wps push button and enrollee pin are good enough for the time being.

The Enrollee PIN method requires AP has PIN input interface.
There are some APs doesn't have PIN input interface.
So we need AP PIN method.

> we should use "wps_reg <bssid> <pin>" to support AP pin function instead of "wps_pin". 

No, "wps_reg <bssid> <pin>" is not a command what you want.
It is a command for special STA which has an ability to configure AP.
The special STA has an ability to configure AP's SSID, encryption type, etc.
Almost smart phones don't have such an ability.

The "wps_pin" command should be used for AP PIN.
You can use this command to input AP pin to out phone.
For example, if AP pin is "12345670" you can type "wps_pin any 123456570".

And the "wps_pin" command could be also used for Enrollee PIN.
You can use this command to generate Enrollee PIN by typing "wps_pin any".
And the generated PIN is used to be inputed to AP.

I have tested "wps_pin" command for AP PIN and Enrollee PIN, these works fine.
My device is Nexus S.
The gaia and gecko is about 1 week ago.
I don't know exact version of my gaia and gecko.
Because I have erased the tree.

According to "https://bugzilla.mozilla.org/show_bug.cgi?id=806020#c5" Linksys E3200 can't be connected with WPS PIN even if via android.
Can you connect to Linksys E4200 with other smart phone ?

Comment 15

[Masashi Honma]

I've gotten a mail from Bugzilla.

"The following is a list of requests people have made of you, which have been outstanding more than 7 days. To avoid disappointing others, please deal with them as quickly as possible."

I think I have already responded to some question. But I've gotten the mail.

What is required to me ?

Comment 16

[Vincent Chang[:vchang][changyihsin]]

(In reply to Masashi Honma from comment #15)
> I've gotten a mail from Bugzilla.
> 
> "The following is a list of requests people have made of you, which have
> been outstanding more than 7 days. To avoid disappointing others, please
> deal with them as quickly as possible."
> 
> I think I have already responded to some question. But I've gotten the mail.
> 
> What is required to me ?

It should be my feedback request. You can cancel it because the bug is not related to wps_pin command.   

I try to connect to my ASUS AP(model name is RT-N16) using wps AP pin. But no luck to get it work. Not sure if it is wpa_supplicant's bug. Because it is failed even if I used my ubuntu notebook.

The WPS procedure is failed when our device responses WPS-WSC_ACK to AP's WPS-M2D message. You can find the attached logcat log with keyword "M2D".    
Do you use wpa_supplicant from external/hostap/wpa_supplicant ? Or it is coming from Nexus S ?

Comment 17

[Vincent Chang[:vchang][changyihsin]]

Attachment: wpsFail in M2D logcat

Comment 18

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 725426 [details] [diff] [review]
Possible fix, patch v1.0

The bug seems not related to wps_pin command, cancel the feedback request.

Comment 19

[Masashi Honma]

> The WPS procedure is failed when our device responses WPS-WSC_ACK to AP's WPS-M2D message. You can find the attached logcat log with keyword "M2D". 

I have watched attached log.
In ordinally case, STA sends M1 and AP sends M2.
But AP sent M2D instead of M2 on line 1656.
This means AP rejected M1 message from STA.

We want to know why AP rejected the M1.
In theory, AP includes the reason for rejection in M2D.
But your AP doesn't send any reason. On line 1657, "config_error=0".

I have a question about your operation.
Have you done any operation on AP side ?
(Like push "use AP PIN button")
Almost AP needs some operations even if the PIN is static value.
The M2D could be sent when you doesn't push "use AP PIN button" yet.

> Do you use wpa_supplicant from external/hostap/wpa_supplicant ? Or it is coming from Nexus S ?

How can I know which one I am using ?

I have flashed B2G by just an ordinally way.

$ git pull
$ ./repo sync
$ ./build.sh -j8
$ ./flash.sh
$ ./flash.sh gaia

Comment 20

[Vincent Chang[:vchang][changyihsin]]

> I have watched attached log.
> In ordinally case, STA sends M1 and AP sends M2.
> But AP sent M2D instead of M2 on line 1656.
> This means AP rejected M1 message from STA.
> We want to know why AP rejected the M1.
> In theory, AP includes the reason for rejection in M2D.
> But your AP doesn't send any reason. On line 1657, "config_error=0".
Not sure why AP sends M2D to us. Is it AP's problem ?  
 
> I have a question about your operation.
> Have you done any operation on AP side ?
> (Like push "use AP PIN button")
> Almost AP needs some operations even if the PIN is static value.
> The M2D could be sent when you doesn't push "use AP PIN button" yet.

Before trying the WPS AP pin method, I have verified push button and client pin methods. Both methods work fine.  

> How can I know which one I am using ?
> 
> I have flashed B2G by just an ordinally way.
> 
> $ git pull
> $ ./repo sync
> $ ./build.sh -j8
> $ ./flash.sh
> $ ./flash.sh gaia
If you don't use adb push manually or modify device specific extract-files.sh located in  device/xxx/xxx/extract-files.sh, you might use the wpa_supplicant from external/hostap/wpa_supplicant.

Comment 21

[Vincent Chang[:vchang][changyihsin]]

Attachment: wireshark capture log when wps failed

Comment 22

[Vincent Chang[:vchang][changyihsin]]

Hey Masashi, can you help to check the wirshark log ?

Comment 23

[Masashi Honma]

> Not sure why AP sends M2D to us. Is it AP's problem ?

We can't know why AP sent M2D from your log.
We can't know it is AP's problem or not from your log.

> Before trying the WPS AP pin method, I have verified push button and client pin methods. Both methods work fine.

I did not asked it.
My question is "What did you do for AP PIN connectio on AP side ?"
On client PIN method, you entered the PIN to AP and push "use client PIN" button on AP.
On PBC method, you pushed "use PBC" button on AP.
On AP PIN method, what did you do on AP side ?

And could you provide AP PIN setting screen shot (maybe it is web interface) ?

Comment 24

[Masashi Honma]

> If you don't use adb push manually or modify device specific extract-files.sh

I didn't use adb push manually and modify device specific extract-files.sh.

> can you help to check the wirshark log ?

I watched the log.
But the M2D message in line 99 and 204 doesn't include correct "Configuration Error Attribute".
So I could not find out cause of M2D.
I looked other frames too. But there was not bad thing.

Now we can't decide which one (B2G or AP) is unsane.
Because both device is not be confirmed as sane.
So I will use my sane AP and B2G device.
Vincent, are you using unagi ?
If so I will borrow unagi from Mozilla Japan and test with it.

Comment 25

[Vincent Chang[:vchang][changyihsin]]

(In reply to Masashi Honma from comment #24)
> > If you don't use adb push manually or modify device specific extract-files.sh
> 
> I didn't use adb push manually and modify device specific extract-files.sh.
> 
> > can you help to check the wirshark log ?
> 
> I watched the log.
> But the M2D message in line 99 and 204 doesn't include correct
> "Configuration Error Attribute".
> So I could not find out cause of M2D.
> I looked other frames too. But there was not bad thing.
> 
> Now we can't decide which one (B2G or AP) is unsane.
> Because both device is not be confirmed as sane.
> So I will use my sane AP and B2G device.
> Vincent, are you using unagi ?
> If so I will borrow unagi from Mozilla Japan and test with it.

Yes, I am using unagi to do the test, and thanks for your help. 
BTW, I don't do anything to configure WPS AP PIN mode in ASUS router. I will attach the screenshot tomorrow.

Comment 26

[Vincent Chang[:vchang][changyihsin]]

Do you get the unagi ? Any update about your test result ?

Comment 28

[Masashi Honma]

> Do you get the unagi ? Any update about your test result ?

I have borrowed unagi.
It worked fine with all WPS methods (Push button, Enrollee PIN, Registrar PIN).

The unagi's Git commit info is below.
2013-02-06 13:19:58
21cedfd1787f4aff26721fc0f160e771d...

Comment 29

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

With increasing report said WPS AP PIN is malfunction, if nothing seems wrong but it still can't work, I think we have to consider WPS_REG as our solution now.

I also looked up what command android uses, it is WPS_REG for AP-PIN, command flows from [1] to [3].
Also, android requires BSSID provided by application, not trying to find out which one by its own. If it comes to WPS_REG, maybe we can require Gaia to provide this information.

[1] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/wifi/java/android/net/wifi/WifiStateMachine.java, line 3180
[2] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/wifi/java/android/net/wifi/WifiConfigStore.java, line 443
[3] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/wifi/java/android/net/wifi/WifiNative.java, line 442

Comment 30

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

I've studied opened source code of ASUS RT-N16(I think they did a good job on this!), only under two conditions will reply M2D:
1. Password ID of M1 satisfies some special condition, or
2. Devices doesn't have AP PIN.

Based on captured packet of https://bugzilla.mozilla.org/attachment.cgi?id=729399, the AP replies M2D because condition 2 is satisfied.
Reference from init code of NT-N16, it seems that ASUS doesn't set AP PIN to its underlying service.

I think this is why it replies M2D with no error.
I am afraid there are tons of APs built based on same BSP as RT-N16, and do the same thing.

For such case, the only way to solve seems to be WPS-REG.

Comment 31

[Masashi Honma]

Hello Chuck Lee.

> I think we have to consider WPS_REG as our solution now.

No. See my Comment 14.
Another reference is "README-WPS". This is on the original wpa_supplicant source code.
http://hostap.epitest.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob;f=wpa_supplicant/README-WPS;h=3d0710937d86762c7c20db19d2c5385314a2b23b;hb=f2f66ad7e805218468aa041985dccaf8719c296e

> Also, android requires BSSID provided by application, not trying to find out which one by its own.

Right. I have already sent a patch to enable the functionality (Bug 791506).
It should be landed.

> Reference from init code of NT-N16, it seems that ASUS doesn't set AP PIN to its underlying service.

Ofcourse AP should set it's own PIN to himself.
Have you done any action at AP side ? I alread asked same question to Vincent Chang. His answer is no.
I think this is why AP PIN method failed.
And I suspect that the AP doesn't have a UI which can set AP PIN.
So I asked to Vincent Chang to get screen shot of the AP UI.

Vincent Chang, when you upload the AP UI screen shot ?

Comment 32

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: WPS UI for RT-N16

Vincent is kind of busy, I upload this for him.

Comment 33

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Masashi Honma from comment #31)
> Hello Chuck Lee.
> 
> > I think we have to consider WPS_REG as our solution now.
> 
> No. See my Comment 14.
> Another reference is "README-WPS". This is on the original wpa_supplicant
> source code.
> http://hostap.epitest.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob;
> f=wpa_supplicant/README-WPS;h=3d0710937d86762c7c20db19d2c5385314a2b23b;
> hb=f2f66ad7e805218468aa041985dccaf8719c296e
> 

I know what the document said, but, this is not a perfect world.
If this turns out to be the only way to be compatible with APs that can be connected through AP-PIN by other devices, I think we have to face the reality.

> > Also, android requires BSSID provided by application, not trying to find out which one by its own.
> 
> Right. I have already sent a patch to enable the functionality (Bug 791506).
> It should be landed.
> 

Well, it's still waiting along with the Gaia PR.
Based on its date, the patch might already outdated.
Would you mind merge them into patch of this bug?

> > Reference from init code of NT-N16, it seems that ASUS doesn't set AP PIN to its underlying service.
> 
> Ofcourse AP should set it's own PIN to himself.
> Have you done any action at AP side ? I alread asked same question to
> Vincent Chang. His answer is no.
> I think this is why AP PIN method failed.
> And I suspect that the AP doesn't have a UI which can set AP PIN.

Yes, I can't find any UI for this.
And there's no single line of code doing things like "hostapd_cli wpa_ap_pin" or set ap_pin in hostapd.conf in the whole source base.

The UI description only says push button and client PIN but also shows AP PIN. That's weird part.

Comment 34

[Masashi Honma]

> Vincent is kind of busy, I upload this for him.

I watched the UI.
The UI does not have UI for AP PIN.
This is just a bug of the AP.

> I think we have to face the reality.

No. Your idea is just an abuse of command.

> Would you mind merge them into patch of this bug?

I have already merged it to master branch some times, but it was not merged.

Blake Kaplan.
I know now you are not module owner. But @vingtetun says you or @fabi1cazenave will manage this patch.
https://github.com/mozilla-b2g/gaia/pull/5697
So I ask to you. Do you have any plan to merge this patch ? If you have, I will modify my patch to master branch.

> "hostapd_cli wpa_ap_pin"

No. The "hostapd_cli wpa_ap_pin" command is for the external Registrar.

Reference is here.
http://hostap.epitest.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob;f=hostapd/README-WPS;h=654b5bcec3342c5f1e5c8d022329c48dd6c022be;hb=f2f66ad7e805218468aa041985dccaf8719c296e

Comment 36

[Dietrich Ayala (:dietrich)]

After discussion with multiple partners in bug 861778, re-blocking on this.

First, we need to know which devices this fails on.

Then:

* We need to determine whether to fix it on the failing device.

* Or if it fails on any device and we cannot or do not want to fix, we need to either disable the feature across all devices.

* Or add some flag for enable/disable the PIN field based on device support.

Either way we have to block - either on fixing the feature or disabling the feature in the UI.

Comment 37

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Following is a list of what we known about AP PIN connectivity

[ Failed ]
1. ASUS RT-N16, Taipei office
2. Baffulo WCR-G300, Taipei office
3. Unknown AP, Bug 859210 Comment 9
4. Unknown NETGEAR AP, Bug 861778 Comment 9

[ Success ]
1. Unknown AP, Comment 28

Comment 38

[Ken Chang[:kenkai]]

(In reply to Dietrich Ayala (:dietrich) from comment #36)
> 
> Either way we have to block - either on fixing the feature or disabling the
> feature in the UI.
Now, Gecko only supports WPA-PBC and My-PIN mode. If we want to support AP-PIN mode, 
we have to do the following things.
1. Rebase and land the patch of Bug 791506.
2. Because the patch of Bug 791506 affects gaia, we also have to modify Gaia code.
3. Rebase and land the patch,"Possible fix, patch v1.0", of this bug.
4. Of cause, do all WPA related tests.
Because this is the new function and we only have short development time, we cannot gurantee
the compatibility and the WPA-PBC/My-PIN function may be affected. Moreover, we don't have 
confidence to finish all things without risks in 3 days.

I think we should just remove the "AP PIN connection" option
(Settings->AP PIN->Wi-Fi->Connect with WPS->AP PIN connection)
and create a follow-up bug for WPA AP-PIN function.

Comment 39

[Dietrich Ayala (:dietrich)]

(In reply to Ken Chang from comment #38)
> I think we should just remove the "AP PIN connection" option
> (Settings->AP PIN->Wi-Fi->Connect with WPS->AP PIN connection)
> and create a follow-up bug for WPA AP-PIN function.

I agree, this is the lowest-risk solution.

Requesting partner input on removing support for WPS AP PIN functionality.

Comment 40

[Masashi Honma]

Hi, Chuck Lee.

> [ Failed ]
> 1. ASUS RT-N16, Taipei office
> 2. Baffulo WCR-G300, Taipei office
> 3. Unknown AP, Bug 859210 Comment 9
> 4. Unknown NETGEAR AP, Bug 861778 Comment 9

Is there any device which can connect to these APs with AP PIN ?

Comment 41

[Masashi Honma]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9255

Pointer to Github pull-request

Comment 42

[Masashi Honma]

Comment on attachment 738845 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9255

><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/9255"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/9255">https://github.com/mozilla-b2g/gaia/pull/9255</a>, or wait 5 seconds to be redirected there automatically.</p>

Comment 43

[Masashi Honma]

> Requesting partner input on removing support for WPS AP PIN functionality.

I just hide the functionality. See my attachment 738845 [details].

Comment 44

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Masashi Honma from comment #40)
> Hi, Chuck Lee.
> 
> > [ Failed ]
> > 1. ASUS RT-N16, Taipei office
> > 2. Baffulo WCR-G300, Taipei office
> > 3. Unknown AP, Bug 859210 Comment 9
> > 4. Unknown NETGEAR AP, Bug 861778 Comment 9
> 
> Is there any device which can connect to these APs with AP PIN ?

No.
For 1 and 2, we can't find a device supports AP PIN in Taipei office.
For 3 and 4, they are reported from partners and we get no further feedback now.

Comment 45

[Vincent Chang[:vchang][changyihsin]]

(In reply to Masashi Honma from comment #43)
> > Requesting partner input on removing support for WPS AP PIN functionality.
> 
> I just hide the functionality. See my attachment 738845 [details].

Thanks for your patch, looks good. But I would like to redirect the review request to gaia peer. Evelyn should be the right person to review the wifi patch.

Comment 46

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Android devices might be rarely support for WAP AP PIN, because in SDK v17, the WPS related APIs are still hidden.
Also, official settings app only supports PBC(Push Button) and Display(My PIN).

The WPS support status of Android phones we can get:
Sony Xperia S     : No support
HTC Butterfly     : PBC, Display
Samsung Galaxy S2 : PBC, Display

Comment 47

[Daniel Coloma:dcoloma]

(In reply to Dietrich Ayala (:dietrich) from comment #39)
> (In reply to Ken Chang from comment #38)
> > I think we should just remove the "AP PIN connection" option
> > (Settings->AP PIN->Wi-Fi->Connect with WPS->AP PIN connection)
> > and create a follow-up bug for WPA AP-PIN function.
> 
> I agree, this is the lowest-risk solution.
> 
> Requesting partner input on removing support for WPS AP PIN functionality.

Agreed

Comment 48

[Kai-Chih Hu [:khu]]

Hi, reporter, would you agree to disable WPS AP PIN support? 
Few highlights: 

* It is broken in Firefox OS for many devices and access points tested.
* It is not widely used.
* It is not supported in Android in many devices.
* The carrier approves removing the feature.

Thanks!

Comment 49

[Vincent Chang[:vchang][changyihsin]]

Based on the Comment 28 and Comment 34, this should be the bug of the AP or the 
interoperability issue between wpa_supplicant and AP. Because the API we used for wps ap pin function is correct in gecko((wps_pin any [PIN]), and the wpa_supplicant helps to do WPS procedure with AP. The negotiation result is then reported to gecko.
In this cause, we got the M2D from AP and wpa_supplicant reports EAP error to gecko.
Not sure if the QC people can help to double confirm our conclusion or not ?

Comment 50

[Ken Chang[:kenkai]]

Michael, can you please provide your advices for comment 49?

Comment 51

[Dietrich Ayala (:dietrich)]

All partners involved in 1.0.1 devices have agreed to remove this feature from the release.

Should a new bug be filed to remove the UI, and this bug be kept open (and blocking-) to track the underlying problem?

Comment 52

[Firefox_Mozilla]

(In reply to khu from comment #48)
> Hi, reporter, would you agree to disable WPS AP PIN support? 
Few
> highlights: 

* It is broken in Firefox OS for many devices and access
> points tested.
* It is not widely used.
* It is not supported in Android in
> many devices.
* The carrier approves removing the feature.

Thanks!


Agree,Thanks!

Comment 53

[Ken Chang[:kenkai]]

(In reply to Dietrich Ayala (:dietrich) from comment #51)
> Should a new bug be filed to remove the UI, and this bug be kept open (and
> blocking-) to track the underlying problem?
Have created Bug 863232.

Comment 54

[Ken Chang[:kenkai]]

Do we need to have this feature on leo?

Comment 55

[Alex Keybl [:akeybl]]

(In reply to Ken Chang from comment #54)
> Do we need to have this feature on leo?

That's more of a question for the product team. Do we need the "AP PIN connection" option from "Connect with WPS" in v1.1, even though we didn't ship it in v1.0.1?

Comment 56

[Peter Dolanjski [:pdol]]

I don't believe that we would block the leo release on this, but we could track it.

Comment 57

[Michael Vines [:m1] [:evilmachines]]

(clearing ni on me since this bug isn't a priority)

Comment 58

[Evelyn Hung]

Comment on attachment 738845 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9255

redirect to Arthur.

Comment 59

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 738845 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9255

r=me. Masashi, thank you for the patch. Please add a comment referring to this bug in the next line of '<!-- Connectivity :: Wi-Fi :: WPS -->', so that we can tell why the item was disabled.

Comment 60

[Masashi Honma]

Hello Arthur Chen.

> r=me

On Comment 53, Ken Chang made a Bug 863232.
Tim Guan-tin Chien made same patch as mine on the Bug.
The Tim's patch was already merged.
So this patch doesn't need review.

Comment 61

[Vincent Chang[:vchang][changyihsin]]

WPS AP pin method is removed in settings app, we don't need this one to prevent interoperability issue.