834119 - add the ability to force users into using a custom bug format

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

add the ability to force users into using a custom bug format.

 - needs to work from advanced and guided entry points
 - needs to be selectable by groups:
   - "include" group
   - "exclude" group
   - you'll be forced into the form if you're in the include group, and not in
     the exclude group

Comment 1

[John Karahalis [:openjck]]

Thanks for filing this.

Just to clarify, I was thinking that people in the "exclude" group would see the guided form by default, but would have the /option/ to opt-out, similar to the way the guided bug entry form has a link called "Switch to the advanced bug entry form."

Comment 2

[John Karahalis [:openjck]]

Would be great to have this for MDN. Any update? Anything we can do to help?

Comment 4

[:glob ✱]

Attachment: patch v1

patch for 4.2.

i ended up not incorporating the 'exclude' part of this request -- it paned out to be impractical.

each form will have to be updated on a case-by-case basis to determine if we want to include a link from the custom form back to the normal bug entry form.  as the form can check group membership directly, this covers the 'exclude' requirement.  this patch doesn't include any such functionality however.

to link to the normal bug entry form, specify a format of __advanced__.  there are no restrictions around who can do this, but now people really have to go out of their way to bypass a format.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 719870 [details] [diff] [review]
patch v1

Review of attachment 719870 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. r=dkl

::: extensions/BMO/Extension.pm
@@ +1052,5 @@
> +    my ($self, $args) = @_;
> +
> +    # always allow overriding the format on the url
> +    my $cgi = Bugzilla->cgi;
> +    if ($cgi->param('format') eq '__advanced__') {

quiet uninitialized warnings:

 if ($cgi->param('format') && $cgi->param('format') eq '__advanced__') {

@@ +1073,5 @@
> +        || return;
> +
> +    # should this user be included?
> +    my $user = Bugzilla->user;
> +    my $include = ref($forced->{include}) ? $forced->{include} : [ $forced->{include} ];

What if we checked for existence of 'include' and if omitted, then assumed to be 'everyone'? I am fine either way.

Comment 6

[John Karahalis [:openjck]]

FWIW, I am fine with the "exclude" feature being omitted. The more we use our form, the more we realize we want to use it for everything. And manually adding a link to a basic form could be a nice workaround.

Comment 7

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #6)
> FWIW, I am fine with the "exclude" feature being omitted. The more we use
> our form, the more we realize we want to use it for everything. And manually
> adding a link to a basic form could be a nice workaround.

glob, he has a fair point in that maybe we should have an override that will take
the user to the normal bug entry form (standard or guided). Unless we really do not
want the user to ever be able to choose a different form for a product. But I 
don't think that is the case and will realistically only be used by those who
know what they are doing.

dkl

Comment 8

[Liz Compton [:liz]]

From Legal's perspective, I can't think of any reason why someone would need to use the standard and not the custom bug entry form.

Comment 9

[David Lawrence [:dkl]]

(In reply to Liz Compton from comment #8)
> From Legal's perspective, I can't think of any reason why someone would need
> to use the standard and not the custom bug entry form.

I am sure that would normally be the case anyway. For now we can just not worry about adding the link until someone specifically asks for us to add it.

dkl

Comment 10

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
modified extensions/BMO/lib/Reports.pm
modified extensions/GuidedBugEntry/template/en/default/pages/guided_products.js.tmpl
modified extensions/GuidedBugEntry/web/js/guided.js
Committed revision 8626.

i changed __advanced__ to __standard__, which results in the user using their normal bug entry form (guided/advanced).