834336 - [Toolbox] Tooltips missing from the developer toolbox

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This may be just the sidebar.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Yes, just the sidebar.

This was more awkward than I originally thought. For whatever reason, certain combinations of browser, tab panel and iframe fail to display their tooltips even when id="aHTMLTooltip" is set.

Adding our own tooltip element and a custom fillInHTMLTooltip method fixes this issue.

Comment 2

[Paul Rouget [:paul]]

Comment on attachment 706355 [details] [diff] [review]
Patch

I don't understand this problem well enough to review it. Can we get someone from browser to take a look at this?

Summary of the situation: in the developer toolbox, in the inspector, there's a sidebar. In this sidebar, tooltips don't show up.

iframes are nested that way:

browser.xul > toolbox.xul > inspectorPanel.xul > csshtmltree.xul

Tooltips from inspectorPanel.xul work. But not in csshtmltree.xul.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Of course we have used the tooltip="aHTMLTooltip" trick but it doesn't seem to work without our own tooltip handler.

This is the same trick as view source. If Gavin can work out exactly why we have no tooltip maybe he has an alternate suggestion.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 706355 [details] [diff] [review]
Patch

I don't know offhand why this is occurring, buy maybe Neil has ideas.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(I agree that it's a good idea to avoid landing a patch like this one before understanding why this bug occurs.)

Comment 6

[Neil Deakin]

Can you provide an example of a tooltip that uses tooltip="aHTMLTooltip" that is working? All of the ones I tried used tooltiptext.

I'd only expect tooltip="aHTMLTooltip" to do anything when aHTMLTooltip existed in the same document.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 706355 [details] [diff] [review]
Patch

(In reply to Neil Deakin from comment #6)
> Can you provide an example of a tooltip that uses tooltip="aHTMLTooltip"
> that is working? All of the ones I tried used tooltiptext.
> 
> I'd only expect tooltip="aHTMLTooltip" to do anything when aHTMLTooltip
> existed in the same document.

The problem is that tooltips for title attributes are not shown for XHTML pages inside XUL iframes. The hack is usually to add tooltip="aHTMLTooltip" to the iframe as there is a hack in browser.js that works around this issue. That is why it worked for our developer tools in the past (bug 729539).

Now that the toolbox is per tab I suppose we no longer have access to that tooltip, hence us needing to create our own.

Gavin, can you still review this? The code is not overly complicated.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #7)
> The problem is that tooltips for title attributes are not shown for XHTML
> pages inside XUL iframes

Comment 2 seems to disagree, and says that it seems to vary based on nesting level. Is it not correct?

Duplicating the browser.xul code is rather gross, and we should avoid it unless necessary. What document's tooltips aren't showing up?

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #8)
> Duplicating the browser.xul code is rather gross, and we should avoid it
> unless necessary. What document's tooltips aren't showing up?

The tooltips for html title attributes in csshtmltree.xul are not showing up (also all tooltips in the sidebar containing this document). Adding a tooltip to the document; the id to the window tag and even manually setting document.tooltipNode fail to solve the problem.

Comment 10

[Neil Deakin]

I decided to just go ahead and fix bug 480356 which should fix this problem. You just need to ensure that <tooltip id="aHTMLTooltip" page="true"/> exists in the document and it will get filled in automatically. (you can use a different id though.)

Your patch is using the view source tooltip code, whereas the patch in bug 480356 uses the better browser.js version. The former, for whatever reason displays elements with label attributes as tooltips, so some of the elements show their label as tooltips. With my patch, this doesn't happen which is correct. If you wanted tooltips for these, those elements should use tooltiptext.

As an aside, I don't see what tooltips could be displayed in the view source window. Are there even any to show?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 706355 [details] [diff] [review]
Patch

Sounds like this patch won't be necessary.

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The patch in bug 480356 fixes this issue properly. We should wait for that to be reviewed and landed before closing this issue.