Closed Bug 834400 Opened 10 years ago Closed 10 years ago

Wrong callback contexts used in aboutDownloads.js

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 21
Tracking Flags:
Tracking Status
firefox20 --- fixed

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Use bind() in download callbacks
1.59 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
We forgot a few binds() calls, so logError() won't work. This fixes them.
Attachment #706006 - Flags: review?(wjohnston)
Attachment #706006 - Flags: review?(wjohnston) → review+
Comment on attachment 706006 [details] [diff] [review]
Use bind() in download callbacks

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 820491
User impact if declined: some download manager errors won't be output correctly (like bug 834048)
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none
Attachment #706006 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/07592e6d5c23
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Attachment #706006 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.