834869 - AudioBuffer's Unlink method should drop js objects

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

I think AudioBuffer's Unlink method is wrong, since it doesn't drop JS objects, like other Unlink methods.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Andrew McCreight [:mccr8]]

You also should put |mChannels.Clear()| in there before it or you'll angry up the use-after-unlink detector.

Comment 3

[(no longer active)]

Attachment: Patch (v2)

Thanks for volunteering to review this.  :P

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 706620 [details] [diff] [review]
Patch (v2)

Review of attachment 706620 [details] [diff] [review]:
-----------------------------------------------------------------

Happy to help!

Comment 5

[(no longer active)]

roc, this will affect your patches.  CCing you to keep you in the loop

Comment 6

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/864464749650

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/864464749650

Comment 8

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.