Closed Bug 834869 Opened 9 years ago Closed 9 years ago

AudioBuffer's Unlink method should drop js objects

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file, 1 obsolete file)

I think AudioBuffer's Unlink method is wrong, since it doesn't drop JS objects, like other Unlink methods.
Attached patch Patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #706566 - Flags: review?(bzbarsky)
You also should put |mChannels.Clear()| in there before it or you'll angry up the use-after-unlink detector.
Attached patch Patch (v2)Splinter Review
Thanks for volunteering to review this.  :P
Attachment #706566 - Attachment is obsolete: true
Attachment #706566 - Flags: review?(bzbarsky)
Attachment #706620 - Flags: review?(continuation)
Comment on attachment 706620 [details] [diff] [review]
Patch (v2)

Review of attachment 706620 [details] [diff] [review]:
-----------------------------------------------------------------

Happy to help!
Attachment #706620 - Flags: review?(continuation) → review+
roc, this will affect your patches.  CCing you to keep you in the loop
https://hg.mozilla.org/mozilla-central/rev/864464749650
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.