834876 - [layers-refactoring] Use texture coords in Effects rather than texture/source rects in Compositor::DrawQuad

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[Nick Cameron [:nrc]]

If we do this we have to expose a lot of crap out of the compositor. Check out LayerManagerOGL::BindAndDrawQuadWithTextureRect. We would need to know about the compositor's ability to do/not do non power of two textures and that we optimise non-repeat textures by breaking them into triangles, which really seems like stuff that should be kept in the compositor.

We always know the texture size and source rect, so I don't see the problem with keeping them as the interface to the compositor.

Comment 2

[Nick Cameron [:nrc]]

We can always use (0, 0, 1, 1) for the texture rect and texture coords for the source rect, if you want a texture coords kind of interface.

Comment 3

[Nick Cameron [:nrc]]

Looks like Bas has done this.