835143 - WebSTK: Implement StkCommandEvent using event generator

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: WIP

> BaseException: JS::Value not supported in simple events!

Hi Olli, do you know what happened? Seems something has to be fixed first, or we should create an interface for each STK event. :(

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

jsvals aren't indeed supported. One could use nsIVariant (XPCVariant).
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.idl#422

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Olli Pettay [:smaug] from comment #2)
> jsvals aren't indeed supported. One could use nsIVariant (XPCVariant).
> http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.
> idl#422

nsIWritableVariant has only |setAsISupports()|.  Does that mean I have to create an interface for at least MozStkCommand?  And I'll also have to make it a DOM interface, one that written by WebIDL?  Am I right?  Thank you.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: WIP2

Rebase.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Bug 868232?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

XPCVariant supports jsvals.

Comment 7

[Edgar Chen [:edgar]]

Steal ... :)

Comment 8

[Edgar Chen [:edgar]]

Attachment: Patch, v3

Use webidl event generator

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 826780 [details] [diff] [review]
Patch, v3

Review of attachment 826780 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/moz.build
@@ +568,5 @@
>          'GamepadButtonEvent.webidl',
>          'GamepadEvent.webidl',
>      ]
>  
> +if CONFIG['MOZ_B2G_RIL']:

Don't.  For interfaces converted to WebIDL, we use Pref="dom.foo.enabled" as you've already had in | MozStkCommandEvent.webidl|.

Comment 10

[Edgar Chen [:edgar]]

Attachment: Patch, v4

1). Address comment #9.
2). Correct test_all_synthetic_events.html.

Comment 11

[Edgar Chen [:edgar]]

Thanks for the review and feedback.

try server: https://tbpl.mozilla.org/?tree=Try&rev=25a85c90931f

Comment 12

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/207fc4458209

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/207fc4458209