Closed Bug 835143 Opened 7 years ago Closed 6 years ago
STK: Implement Stk Command Event using event generator
No description provided.
> BaseException: JS::Value not supported in simple events! Hi Olli, do you know what happened? Seems something has to be fixed first, or we should create an interface for each STK event. :(
jsvals aren't indeed supported. One could use nsIVariant (XPCVariant). http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.idl#422
(In reply to Olli Pettay [:smaug] from comment #2) > jsvals aren't indeed supported. One could use nsIVariant (XPCVariant). > http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect. > idl#422 nsIWritableVariant has only |setAsISupports()|. Does that mean I have to create an interface for at least MozStkCommand? And I'll also have to make it a DOM interface, one that written by WebIDL? Am I right? Thank you.
Attachment #706883 - Attachment is obsolete: true
XPCVariant supports jsvals.
Steal ... :)
Assignee: vyang → echen
Use webidl event generator
Attachment #777787 - Attachment is obsolete: true
Comment on attachment 826780 [details] [diff] [review] Patch, v3 Review of attachment 826780 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/webidl/moz.build @@ +568,5 @@ > 'GamepadButtonEvent.webidl', > 'GamepadEvent.webidl', > ] > > +if CONFIG['MOZ_B2G_RIL']: Don't. For interfaces converted to WebIDL, we use Pref="dom.foo.enabled" as you've already had in | MozStkCommandEvent.webidl|.
1). Address comment #9. 2). Correct test_all_synthetic_events.html.
Attachment #826780 - Attachment is obsolete: true
Attachment #827314 - Flags: feedback?(vyang)
Attachment #827314 - Flags: feedback?(vyang) → feedback+
Attachment #827314 - Flags: review?(bugs)
Thanks for the review and feedback. try server: https://tbpl.mozilla.org/?tree=Try&rev=25a85c90931f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.