Closed Bug 835143 Opened 7 years ago Closed 6 years ago

WebSTK: Implement StkCommandEvent using event generator

Categories

(Core :: DOM: Events, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: vicamo, Assigned: edgar)

References

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Assignee: nobody → vyang
Attached patch WIP (obsolete) — Splinter Review
> BaseException: JS::Value not supported in simple events!

Hi Olli, do you know what happened? Seems something has to be fixed first, or we should create an interface for each STK event. :(
Attachment #706883 - Flags: feedback?(bugs)
jsvals aren't indeed supported. One could use nsIVariant (XPCVariant).
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.idl#422
Attachment #706883 - Flags: feedback?(bugs)
(In reply to Olli Pettay [:smaug] from comment #2)
> jsvals aren't indeed supported. One could use nsIVariant (XPCVariant).
> http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.
> idl#422

nsIWritableVariant has only |setAsISupports()|.  Does that mean I have to create an interface for at least MozStkCommand?  And I'll also have to make it a DOM interface, one that written by WebIDL?  Am I right?  Thank you.
Flags: needinfo?(bugs)
Attached patch WIP2 (obsolete) — Splinter Review
Rebase.
Attachment #706883 - Attachment is obsolete: true
XPCVariant supports jsvals.
Flags: needinfo?(bugs)
Steal ... :)
Assignee: vyang → echen
Attached patch Patch, v3 (obsolete) — Splinter Review
Use webidl event generator
Attachment #777787 - Attachment is obsolete: true
Comment on attachment 826780 [details] [diff] [review]
Patch, v3

Review of attachment 826780 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/moz.build
@@ +568,5 @@
>          'GamepadButtonEvent.webidl',
>          'GamepadEvent.webidl',
>      ]
>  
> +if CONFIG['MOZ_B2G_RIL']:

Don't.  For interfaces converted to WebIDL, we use Pref="dom.foo.enabled" as you've already had in | MozStkCommandEvent.webidl|.
Attached patch Patch, v4Splinter Review
1). Address comment #9.
2). Correct test_all_synthetic_events.html.
Attachment #826780 - Attachment is obsolete: true
Attachment #827314 - Flags: feedback?(vyang)
Attachment #827314 - Flags: feedback?(vyang) → feedback+
Attachment #827314 - Flags: review?(bugs)
Attachment #827314 - Flags: review?(bugs) → review+
Thanks for the review and feedback.

try server: https://tbpl.mozilla.org/?tree=Try&rev=25a85c90931f
https://hg.mozilla.org/mozilla-central/rev/207fc4458209
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.