Closed
Bug 835150
Opened 12 years ago
Closed 11 years ago
Remove fast-package make target, references to MOZ_FAST_PACKAGE
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: Ms2ger, Assigned: Cykesiopka)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
2.33 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
It's useless now.
![]() |
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8344298 -
Flags: review?(mshal)
Comment 2•11 years ago
|
||
Comment on attachment 8344298 [details] [diff] [review]
bug835150_v1.patch
> # helper target for mobile
>-build_and_deploy: build fast-package install
>+build_and_deploy: build install
Doesn't this need to still build the package? Eg:
build_and_deploy: build package install
I think by removing the dependency completely you are changing the behavior of build_and_deploy.
Attachment #8344298 -
Flags: review?(mshal) → feedback+
![]() |
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2)
> Doesn't this need to still build the package? Eg:
>
> build_and_deploy: build package install
>
> I think by removing the dependency completely you are changing the behavior
> of build_and_deploy.
Yes, thanks for catching that!
![]() |
Assignee | |
Comment 4•11 years ago
|
||
+ Add |package| dependency back to build_and_deploy
Assignee: nobody → cykesiopka.bmo
Attachment #8344298 -
Attachment is obsolete: true
Attachment #8345005 -
Flags: review?(mshal)
Comment 5•11 years ago
|
||
Attachment #8345005 -
Flags: review?(mshal) → review+
![]() |
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•11 years ago
|
Whiteboard: [qa-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•