Closed Bug 835150 Opened 8 years ago Closed 7 years ago

Remove fast-package make target, references to MOZ_FAST_PACKAGE

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: Ms2ger, Assigned: Cykesiopka)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

It's useless now.
Attached patch bug835150_v1.patch (obsolete) — Splinter Review
Attachment #8344298 - Flags: review?(mshal)
Comment on attachment 8344298 [details] [diff] [review]
bug835150_v1.patch

> # helper target for mobile
>-build_and_deploy: build fast-package install
>+build_and_deploy: build install

Doesn't this need to still build the package? Eg:

build_and_deploy: build package install

I think by removing the dependency completely you are changing the behavior of build_and_deploy.
Attachment #8344298 - Flags: review?(mshal) → feedback+
(In reply to Michael Shal [:mshal] from comment #2)
> Doesn't this need to still build the package? Eg:
> 
> build_and_deploy: build package install
> 
> I think by removing the dependency completely you are changing the behavior
> of build_and_deploy.

Yes, thanks for catching that!
+ Add |package| dependency back to build_and_deploy
Assignee: nobody → cykesiopka.bmo
Attachment #8344298 - Attachment is obsolete: true
Attachment #8345005 - Flags: review?(mshal)
Comment on attachment 8345005 [details] [diff] [review]
bug835150_v2.patch

Looks good to me!
Attachment #8345005 - Flags: review?(mshal) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3df5b335e5a8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.