835173 - Make it possible to exclude platforms from lastGoodFunc/lastGoodRev for choosing a nightly rev

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Phil Ringnalda (:philor)]

There's no end in sight to our desire to do things like only build win64 on mozilla-central, but build nightlies of it, and only build ASan on mozilla-central, but build nightlies of it.

The first half of bug 834222 was almost certainly about win64 (though there's one nightly that almost looks like it was automatically scheduled on a rev with a red win64 opt build, it may well have been manually triggered just after the time it would, or more accurately would not, have been automatically scheduled). The second half is almost certainly about the way ASan is now burning.

If we're going to keep saying "okay, you can have on-push and nightly builds hidden on mozilla-central" then we also need to tell the scheduler to ignore those things which it's okay to burn, and near as I can tell, right now we can't.

Comment 1

[Ed Morley [:emorley]]

This caused us to not have nightlies built on tip, due to bug 840948.

Now that Win64 is tier3, I see this happening more and more.

Comment 2

[Phil Ringnalda (:philor)]

Another, possibly better, idea would be to come up with a wittier tree name than "mozilla-fringe" and report win64 and asan and dxr and xulrunner and valgrind and b2g desktop as visible jobs on a separate tree.

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to Phil Ringnalda (:philor) from comment #2)
> Another, possibly better, idea would be to come up with a wittier tree name
> than "mozilla-fringe" and report win64 and asan and dxr and xulrunner and
> valgrind and b2g desktop as visible jobs on a separate tree.

I thought fringe was kind of witty.  Perhaps they are relevant in an alternate universe. ;-)

Comment 4

[Ed Morley [:emorley]]

(In reply to Bill Gianopoulos [:WG9s] from comment #3)
> I thought fringe was kind of witty.  Perhaps they are relevant in an
> alternate universe. ;-)

Heh +1

Comment 5

[Chris AtLee [:catlee]]

Attachment: Add support for a new platform configuration variable, consider_for_nightly

If consider_for_nightly is False, then we won't look at this platform's builds for the last good revision function

Comment 6

[Chris AtLee [:catlee]]

Attachment: disable consider_for_nightlies for win64 and asan builds

this means that these builds can burn and burn and burn without preventing the nightlies from happening

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to Chris AtLee [:catlee] from comment #6)
> Created attachment 717142 [details] [diff] [review]
> disable consider_for_nightlies for win64 and asan builds
> 
> this means that these builds can burn and burn and burn without preventing
> the nightlies from happening

But since the idea is that thsi will be used in conjunction with these build being hidden form tinderboxpushlog, that behavior would seem to be appropriate.

Comment 8

[Ed Morley [:emorley]]

Are these ready to land?

(Today's nightlies happened on an old rev due to burning Asan)

Comment 9

[Chris AtLee [:catlee]]

Yup. Was traveling yesterday, so will land these today.

Comment 10

[John Hopkins (:jhopkins)]

in production