835255 - B2G RIL: marionette test, dom/network/tests/marionette/test_mobile_operator_name.js, fail when enable EF_PNN

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar]]

When I tried to implement dynamic SIM EF in emulator [1], I found if enable the EF_PNN, marionette tests [2] will fail. So open this bug for tracking.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=833174
[2] dom/network/tests/marionette/test_mobile_operator_name.js

Comment 1

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Part 1: we should use PLMN from network when phone is in PLMN that is not listed in OPL

According to 3GPP TS 31.102 Sec. 4.2.58: "If the EF_OPL is not present, then the first record in EF_PNN is used for the default network name when registered in the HPLMN (if the EHPLMN list is not present or is empty) or an EHPLMN (if the EHPLMN list is present)."

In current getNetworkNameFromICC, we use the first PNN record as network name when device is in home PLMN but current PLMN is not in OPL, no matter OPL is present or not.

Comment 2

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Part 2: test cases

Adding test cases:
1. Device is in a PLMN that is not home nor listed in OPL.
2. Device is in a PLMN that is listed in OPL but not home.
3. Device is in the home PLMN but the PLMN is not listed in OPL.

Comment 3

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Pull request: adding EF_OPL and enabling EF_PNN

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 735127 [details] [diff] [review]
Part 1: we should use PLMN from network when phone is in PLMN that is not listed in OPL

Review of attachment 735127 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late. Could you help having another revision?

::: dom/system/gonk/ril_worker.js
@@ +10940,5 @@
> +      }
> +
> +      // Return a new object to avoid global variable, PNN, be modified by accident.
> +      return { fullName: pnnEntry.fullName || "",
> +               shortName: pnnEntry.shortName || "" };

I think you can reuse these lines with following code that deals with valid OPL entries.

Comment 5

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

try: https://tbpl.mozilla.org/?tree=Try&rev=427e17750f47
see if we can land the first part before updating emulator.

Comment 6

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Attachment: Part 1: we should use PLMN from network when phone is in PLMN that is not listed in OPL v2

Comment 7

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Landing the first part:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec43d0f8dca6

Then we should update emulator in tbpl, then land the test case.

Comment 8

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Hi Vicamo, could you help to checkin the pull request?

https://github.com/mozilla-b2g/platform_external_qemu/pull/27

Thanks.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec43d0f8dca6

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Patrick Wang [:kk1fff] from comment #8)
> Hi Vicamo, could you help to checkin the pull request?

Done :)

Comment 12

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Reopening because the test part haven't been landed.

Comment 13

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

emulator is updated, try the test case: https://tbpl.mozilla.org/?tree=Try&rev=1070f9d54d2e

Comment 14

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

https://hg.mozilla.org/projects/birch/rev/38610554be03

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38610554be03