835610 - Work - [polish] Firefox app bar location text does not revert to the previous value when user presses escape

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Load a page in Metro Firefox.
2. After the page loads, focus the location bar.
3. Type a word.
4. Press the Escape key.

Expected results: The URL bar reverts to the address of the current page.

Actual results: The URL bar hides, but still contains the typed word.

Comment 1

[Allison Naaktgeboren :ally]

Attachment: wip - functional, needs some code hygiene

- I left the new {} braces in one case of handleEscape() because it is in line with our style guide.
- I left some of the more interesting error console logging for you in case you'd like to see the output during feedback.
- I think lastKnownGoodURL should move into browserUI, and I welcome better names for that variable. :/

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 744902 [details] [diff] [review]
wip - functional, needs some code hygiene

Review of attachment 744902 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this looks good to me.

::: browser/metro/base/content/browser-ui.js
@@ +57,5 @@
>    });
>  });
>  
> +let lastKnownGoodURL = ""; //used when the user wants to escape unfinished url entry
> +// TODO I think this belongs in browserUI,not out here with Elements

I agree.

Comment 3

[Allison Naaktgeboren :ally]

Attachment: save urls when they are set

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 746051 [details] [diff] [review]
save urls when they are set

Review of attachment 746051 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser-ui.js
@@ +77,4 @@
>    get _back() { return document.getElementById("cmd_back"); },
>    get _forward() { return document.getElementById("cmd_forward"); },
>  
> +  lastKnownGoodURL : "", //used when the user wants to escape unfinished url entry

Nit: no space before ":"

No rationale except consistency.  Mozilla JS code overall is divided on this issue, but this is the dominant style in Metro so I've added it to https://wiki.mozilla.org/Firefox/Windows_8_Metro_Style_Guides#JS

Comment 5

[Allison Naaktgeboren :ally]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/aa00d8de9a79

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa00d8de9a79