836043 - Use icons for tab switching in Tabs UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

It's better to use icons for tabs -- instead of text or spinner -- for switching different panels in tabs ui.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Icon TabWidget

This patch adds a new IconTabWidget to handle the tab switching.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Dark toolbar

This adds a dark toolbar. The divider should be underneath the buttons, hence a RelativeLayout is used.

Since the toolbar is dark, the tabs button has to be dark when in opened state.
Also, the same should be reflected in personas.

Late realization: I could have renamed the tabs_tray_selected_bg to tabs_tray_dark_bg. :(

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 707851 [details] [diff] [review]
Part 1: Icon TabWidget


>diff --git a/mobile/android/base/GeckoViewsFactory.java b/mobile/android/base/GeckoViewsFactory.java

Can you remove the Log that always outputs the view anme? Let's just keep the Log that warns for a missing view.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 3: 7" tablet tabs-ui

I had wrongly copied the tab-icons to xlarge folder instead of large folder. That's rectified in this patch.

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4271cc336457
https://hg.mozilla.org/integration/mozilla-inbound/rev/445674b9dd09
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffe303f6ee85

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4271cc336457
https://hg.mozilla.org/mozilla-central/rev/445674b9dd09
https://hg.mozilla.org/mozilla-central/rev/ffe303f6ee85

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 707851 [details] [diff] [review]
Part 1: Icon TabWidget

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New UI.
User impact if declined: Spinners on phones and tablets to switch tab panels.
Testing completed (on m-c, etc.): Landed in m-c on 01/31
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: None.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 707866 [details] [diff] [review]
Part 2: Dark toolbar

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New UI.
User impact if declined: Darker toolbar for  tabs-ui will not be seen.
Testing completed (on m-c, etc.): Landed in m-c on 01/31
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: None.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 708309 [details] [diff] [review]
Part 3: 7" tablet tabs-ui

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New UI.
User impact if declined: 7" will have blurry icons.
Testing completed (on m-c, etc.): Landed in m-c on 01/31
Risk to taking this patch (and alternatives if risky): Very low. Just moving images around.
String or UUID changes made by this patch: None.

Comment 10

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/af947a1a7dd3
https://hg.mozilla.org/releases/mozilla-aurora/rev/39dea33472a1
https://hg.mozilla.org/releases/mozilla-aurora/rev/fbf89bfb81d3

Comment 11

[Siddhartha Dugar [:sdrocking]]

The icon for Sync should have been arrows in a circle, much like the desktop Sync button. The current icon is similar to what they use in Android to indicate connectivity.

Comment 12

[Andreea Pod]

Tabs have icons for switching different panels in Tabs UI. Closing bug as verified fixed on: Nightly 21.0a1(2013-02-07) and Aurora 20.0a2(2013-02-07), using Samsung Galaxy Tab 10.1