Closed Bug 836088 Opened 8 years ago Closed 8 years ago

"TableTicker.cpp:823:9: warning: unused variable 'platformData' [-Wunused-variable]", on Mac OS X opt builds

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix
1.65 KB, patch
BenWa
: review+
Details | Diff | Splinter Review 
Build warning, on Mac OS X opt builds:
{
/builds/slave/try-osx64/build/obj-firefox/i386/config/nsinstall -L /builds/slave/try-osx64/build/obj-firefox/i386/tools/profiler -m 644 "_xpidlgen/profiler.xpt" "../../dist/bin/components"
../../../../tools/profiler/TableTicker.cpp:823:9: warning: unused variable 'platformData' [-Wunused-variable]
  void *platformData = nullptr;
        ^
1 warning generated.
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=19249692&tree=Try
Attached patch fix — — Splinter Review 
This just moves the variable declaration down to where it's used (in a block that's not compiled for OS X).
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #707874 - Flags: review?(bgirard)
Attachment #707874 - Flags: review?(bgirard) → review+
Blocks: 836150
https://hg.mozilla.org/mozilla-central/rev/1efe0f7e93d0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.