836150 - Mark tools/profiler as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Daniel Holbert [:dholbert]]

tools/profiler is nearly warning-free. Filing this bug on marking it as FAIL_ON_WARNINGS, once its last warnings are fixed.

This try server run shows that we're good aside from one remaining windows warning (which I filed bug 836149 on):
https://tbpl.mozilla.org/?tree=Try&rev=466b8eb2c2d1

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Requesting review. (of course, I won't land until dependent bugs are fixed & this is green on Try)

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 707930 [details] [diff] [review]
fix

Yay

Comment 3

[Daniel Holbert [:dholbert]]

I ended up exempting MSVC from the FAIL_ON_WARNINGS annotation, due to one remaining mysterious MSVC warning (Bug 836185).

(So, I just added an "ifndef _MSC_VER" wrapper, following the example of the final patch in bug 824247).

Landed (w/ that tweak): https://hg.mozilla.org/integration/mozilla-inbound/rev/0f78cc92ab1a

Comment 4

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/0f78cc92ab1a