Closed
Bug 836150
Opened 13 years ago
Closed 13 years ago
Mark tools/profiler as FAIL_ON_WARNINGS
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
698 bytes,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
tools/profiler is nearly warning-free. Filing this bug on marking it as FAIL_ON_WARNINGS, once its last warnings are fixed.
This try server run shows that we're good aside from one remaining windows warning (which I filed bug 836149 on):
https://tbpl.mozilla.org/?tree=Try&rev=466b8eb2c2d1
|
Assignee | |
Comment 1•13 years ago
|
||
Requesting review. (of course, I won't land until dependent bugs are fixed & this is green on Try)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 707930 [details] [diff] [review]
fix
Yay
Attachment #707930 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
I ended up exempting MSVC from the FAIL_ON_WARNINGS annotation, due to one remaining mysterious MSVC warning (Bug 836185).
(So, I just added an "ifndef _MSC_VER" wrapper, following the example of the final patch in bug 824247).
Landed (w/ that tweak): https://hg.mozilla.org/integration/mozilla-inbound/rev/0f78cc92ab1a
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•