Mark tools/profiler as FAIL_ON_WARNINGS

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla21
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

tools/profiler is nearly warning-free. Filing this bug on marking it as FAIL_ON_WARNINGS, once its last warnings are fixed.

This try server run shows that we're good aside from one remaining windows warning (which I filed bug 836149 on):
https://tbpl.mozilla.org/?tree=Try&rev=466b8eb2c2d1
Posted patch fixSplinter Review
Requesting review. (of course, I won't land until dependent bugs are fixed & this is green on Try)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #707930 - Flags: review?(bgirard)
Comment on attachment 707930 [details] [diff] [review]
fix

Yay
Attachment #707930 - Flags: review?(bgirard) → review+
I ended up exempting MSVC from the FAIL_ON_WARNINGS annotation, due to one remaining mysterious MSVC warning (Bug 836185).

(So, I just added an "ifndef _MSC_VER" wrapper, following the example of the final patch in bug 824247).

Landed (w/ that tweak): https://hg.mozilla.org/integration/mozilla-inbound/rev/0f78cc92ab1a
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/0f78cc92ab1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Blocks: 855010
You need to log in before you can comment on or make changes to this bug.