Closed Bug 836126 Opened 10 years ago Closed 10 years ago

obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [WebRTC] [blocking-webrtc-][qa-])

Attachments

(1 file)

fix v1
1.01 KB, patch
ekr
: review+
Details | Diff | Splinter Review 
{
obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

This is for a loop iterating up to sizeof(something), w/ a signed loop variable.

We should use size_t for the loop variable, to match the type of sizeof.
Attached patch fix v1 — — Splinter Review 

        Attachment #707900 -
        Flags: review?(ekr)

    
  
Summary: obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare → obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

    
  
Blocks: 836570
Whiteboard: [WebRTC] [blocking-webrtc-]

    
    

    
  
Comment on attachment 707900 [details] [diff] [review]
fix v1

Review of attachment 707900 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

        Attachment #707900 -
        Flags: review?(ekr) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/92542cbceb07
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-][qa]
Whiteboard: [WebRTC] [blocking-webrtc-][qa] → [WebRTC] [blocking-webrtc-][qa-]

          You need to log in
          before you can comment on or make changes to this bug.