Closed
Bug 836126
Opened 10 years ago
Closed 10 years ago
obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [WebRTC] [blocking-webrtc-][qa-])
Attachments
(1 file)
1.01 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
{ obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] } This is for a loop iterating up to sizeof(something), w/ a signed loop variable. We should use size_t for the loop variable, to match the type of sizeof.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #707900 -
Flags: review?(ekr)
Assignee | ||
Updated•10 years ago
|
Summary: obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare → obj/media/mtransport/build/dtlsidentity.cpp:44:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Updated•10 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-]
Comment 2•10 years ago
|
||
Comment on attachment 707900 [details] [diff] [review] fix v1 Review of attachment 707900 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #707900 -
Flags: review?(ekr) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/92542cbceb07
Flags: in-testsuite-
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/92542cbceb07
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•10 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-][qa]
Updated•10 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-][qa] → [WebRTC] [blocking-webrtc-][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•