836570 - Mark media/mtransport/build as FAIL_ON_WARNINGS on non-MSVC compilers

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

W/ dependent bugs fixed, the source files built by media/mtransport/build/Makefile.in are warning-free[1].

Marking 

[1] (We've actually still got one MSVC warning that seems to be from a third-party header not properly checking whether a macro is defined.  I filed bug 836500 on that one, and I'm excluding MSVC from this bug's FAIL_ON_WARNINGS annotation for now.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Here's a green try run w/ this being tested on most of our platforms (I skipped a few, e.g. Linux32, to save on resources):
 https://tbpl.mozilla.org/?tree=Try&rev=1faeab6ced1d

Comment 2

[Daniel Holbert [:dholbert]]

(The "#ifndef _MSC_VER" wrapper is the pattern we're using tree-wide for cases where we need to exempt MSVC from FAIL_ON_WARNINGS, per bug 824247 comment 7).

Comment 3

[Daniel Holbert [:dholbert]]

Green try run, w/ helper-bugs all fixed (all of which have already landed on inbound, except for bug 836196, which is awaiting review):
  https://tbpl.mozilla.org/?tree=Try&rev=ce8a81a060ec

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4088b236634

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e4088b236634