836166 - [Dialer] Without SIM Card, the dialer app still pop up an out going call screen if you dial a normal number.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Vincent Liu[:vliu]]

STR for this issue.

1. Make sure there is no SIM Card in device.
2. Launch dialer app and make a call.
3. The device show "No network connection" about 1 second and 
4. Then, an out going call screen pops up.

Expected result:
We shouldn't have step 4.

Actuall result:
Step 4 happens.

Comment 1

[Vincent Liu[:vliu]]

Without SIM Card, I can still dial emergency call. It means cs_render() will still be called for showing different state. I think the problem might be how dialer app dial with the non-emergency call number.

Comment 2

[Vincent Liu[:vliu]]

As I checked the source code in dialer app, I didn't see any emergency call number checking in dialing flow. I think this is the problem I saw for this issue. I am not sure if this is for UX design or a real bug we should fix. Etienne, can you please give me any info for this issue? Thanks

Comment 3

[ayman maat :maat]

If the SIM is not in the device when the end user attempts to make a call we require a message informing the end user that there is no network coverage: 

**PATH**
1) remove SIM from phone and reboot device
2) open dial app
3) enter emergency number
4) press call

**EXPECTED**
message overlays screen informing the user that 'mobile network is unavailable'. 
message should have one CTA labelled 'OK' 
selecting OK returns the user to the dialer.

**ACTUAL**
Then, an out going call screen pops up.

Comment 4

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia PR

I was pretty sure this was part of bug 833982 but apparently not...

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Vincent Liu[:vliu] from comment #2)
> As I checked the source code in dialer app, I didn't see any emergency call
> number checking in dialing flow.

We actually can't check from the content if a number is an emergency call number...

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

We will need to dial in order to know if it's an emergency number or not.

Even, in some countries like Brazil and UK, calls to emergency number are forbidden if no SIM card.

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to Francisco Jordano [:arcturus] from comment #6)
> We will need to dial in order to know if it's an emergency number or not.
> 
> Even, in some countries like Brazil and UK, calls to emergency number are
> forbidden if no SIM card.

Note that the patch is not about this :)

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Etienne, yep sorry, my comment was before taking a look to patch :).

I think we should uplift this bug to 1.0.0 and v1-train isnt?

Comment 9

[Etienne Segonzac (:etienne)]

(In reply to Francisco Jordano [:arcturus] from comment #8)
> Etienne, yep sorry, my comment was before taking a look to patch :).
> 
> I think we should uplift this bug to 1.0.0 and v1-train isnt?

Makes sense.

Comment 10

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/05de5726720b1c98671cdcb983b7ee493b271e2b

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 708599 [details]
Pointer to gaia PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): regression
User impact if declined: we will display (and hide) the attention screen when user tries to make a call without sim. This breaks the UX and could be a reason for not passing the certification
Testing completed: yes
Risk to taking this patch (and alternatives if risky):not risky

Comment 12

[David Scravaglieri [:scravag]]

Daniel, to be sure, is it a certification blocker ?

Comment 14

[Daniel Coloma:dcoloma]

yes, it is, nominating so you can uplift to 1.0.0

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Hi, this patch did not apply cleanly to v1-train or v1.0.0.  Please merge manually.  The following might work for you, but is only offered as a starting point:

git checkout v1-train
git cherry-pick -m1 05de5726720b1c98671cdcb983b7ee493b271e2b
<resolve merge conflict, commit>
git checkout v1.0.0
git cherry-pick $(git log -n1 v1-train --pretty="%H")

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to John Ford [:jhford] from comment #15)
> Hi, this patch did not apply cleanly to v1-train or v1.0.0.  Please merge
> manually.  The following might work for you, but is only offered as a
> starting point:
> 
> git checkout v1-train
> git cherry-pick -m1 05de5726720b1c98671cdcb983b7ee493b271e2b
> <resolve merge conflict, commit>
> git checkout v1.0.0
> git cherry-pick $(git log -n1 v1-train --pretty="%H")

I've found myself in a weird situation when trying to uplift this bug (Etienne is on holidays)

As per John Ford comment, this patch doesn't apply automatically to v1-train so I was going to resolve the conflict by myself cherry picking the changes, but I found a weird surprise.

At the beginning I though that bug 833982 wasn't applied:

https://bugzilla.mozilla.org/show_bug.cgi?id=833982 (Trying to make a call when no voice network is available silently fails with no feedback to user)

But that bug has all the correct flags to have been uplifted to v1-train (I mean is a tef+ and status-b2g18-v1.0.0 fixed), so I checked again and realised that the patch is 'partially' applied to v1-train, if you check the git blame and logs:

v1-train for file apps/communications/dialer/js/telephony_helper.js:

https://github.com/mozilla-b2g/gaia/blame/v1-train/apps/communications/dialer/js/telephony_helper.js

You will see how it doesn't include any reference to bug 833982 but the changes that this bug introduced.

How this could happen? Easy, we do have another bug 833232 that was checked in, and we did a manually uplift to v1-train, look at comment 14:

Landed on master. https://github.com/mozilla-b2g/gaia/commit/4e5b4b1e696ca210be2168ec27d25eb7b610443b
Landed on v1-train. https://github.com/mozilla-b2g/gaia/commit/00c034963f436de06e517ca93434ef7e885cc5e8
Landed on v1.0.0. https://github.com/mozilla-b2g/gaia/commit/da39f0b896ef86aaa7dccba6ef6941edde745f37

Despite that this bug is a no brainer when we did the uplift to v1-train I think we added more things than expected (check what the patch for this bug and what's the PR for v1-train).

So, IMHO, maybe I'm wrong, we have an inconsistent state right now affecting the dialer app, we didn't uplift 833982, but we have it now partially cause of 833232.

Cheers!

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 49dd7667397c7d74389fa5939ebc84bcefd23c15
v1.0.0: 663187746533377ccd2c33a70c587c241bc1f512

Comment 18

[mdaniloff]

Verified Fixed in Unagi build #20130214070203
Dec 5th Kernel

when the user makes a call with no sim card inserted, a "no network connection" screen appears and message overlays screen informing the user that 'mobile network is unavailable' message confirmation:'OK' 
selecting OK returns the user to the dialer.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Just putting this back to tef+ since this got on the right branches, and that is the same as a shira+ so not clear why this was moved to shira? - perhaps an error?