836192 - [Keyboard] In Silent mode,keyboard still make sounds

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Leo]

1. Title : In Silent Mode,Keyboard still make sounds
2. Precondition : Setting >> Keyboard >> Click Sound >> Check, Mode >> Silent Mode set 
3. Tester's Action : Message >> New Message >> Enter Text >> Press Keyboard                  
4. Detailed Symptom (ENG.) : Device is in silent mode but Pressing on keyboard still making sounds
5. GAIA version : 7b8dea7e7ec377a2143151bbe5e9998d87f7b36d
6. Expected : In silent Mode,even if the keyboard sound is in ON state,Keyboard should not make sounds.
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Leo]

Attachment: Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/8171

Please review the patch at https://github.com/mozilla-b2g/gaia/pull/8171.

Comment 2

[Walter Chen[:ypwalter][:wachen]]

Rudy, Evelyn,
If you two get any free time, could you please help us with the reviewing?

Many thanks,
Walter

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

This is not a blocker for release but we'll track and consider a low risk uplift to v1-train when available.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 715124 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/8171

r=me with some lint nits addressed.
Thank you.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

On Gaia master, fixed with,
https://github.com/mozilla-b2g/gaia/commit/9bf06f845591633e03b8a5ca2afb760e577dd443

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 9bf06f845591633e03b8a5ca2afb760e577dd443 as:
v1-train: d8b299f65c2eb63173783286d44811e2f8e460fd

Comment 7

[Mike Lee [:mlee]]

Marking as blocking tef? and requesting uplift.

Comment 8

[William Hsu [:whsu]]

Hi, all,

Sorry for the late reply.
Verified this fix. It work as usual now.

* Reproduction build: (releases/mozilla-b2g18_v1_0_1/2013-02-18-08)
  - Mercurial-Information:
    + Gecko revision="059a7e0badf7"
    + Gaia revision="e6c2aa2befb9"
  - Git-Information:
    + Gecko revision="0ecc076d496e3be9b44131a2923897edc4e8116c"
    + Gaia" revision="edaca00b1eb7534120b6255db5d5200fb1d86d65"

* Verified build: (Mozilla-central-unagi/2013-04-05-10-34-53)
  - Mercurial-Information:
    + Gecko revision="40a228f74389"
    + Gaia revision="fc2f77af69be"
  - Git-Information:
    + Gecko revision="39839490f961009f7d0e259d85e6931cfd11263d"
    + Gaia" revision="3f824d1dcb15c2c2f3e90483adc9f9d01f122477"


Thanks!


Best Regards,
William

Comment 9

[Leo]

Do you consider the other sounds also?
- Settings - sound - other sounds and notification settings

If you modify only keyboard, it's different action with other sounds case.

Comment 10

[William Hsu [:whsu]]

Hi, Leo,

Thanks for the suggestion.
But I cannot 100% understand what you want to express.
Could you please use a case to describe it?

By the way, I verified this bug by the above reproduction steps.
So, it works. I also found other bugs relate to sound function during the test.
e.g. The dial keyboard still sound while enter silent.
But that's different cases, so I would like to submit another case to trace it.
Thanks!


Best Regards,
William

Comment 11

[Leo]

Hi,

In silent mode or vibration mode,
keypad, camera shutter, sent message and unlock screen(Settings - sound - other sounds) sound plays also.

In case of Notification and keyboard, vibration also make similar action like sound in silent mode

Thanks

Comment 12

[William Hsu [:whsu]]

Hi, all,

Thanks for the help. Attach the related bug. FYI.
Bug 860156 - [B2G][Settings][Sound] In silent mode, the keypad, camera shutter, sent message and unlock screen still have sound.

Comment 13

[James Lal [:lightsofapollo]]

v1.0.1: 7d519e4

Not sure but something is causing this to be missed by our uplift queries...