836206 - Split out or rewrite CommonUtils.jsonLoad/jsonSave

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Richard Newman [:rnewman]]

These are the only two consumers of FileUtils and NetUtils in services/common/utils.jsm. They're only used by AITC and Sync, the former only once each.

We should consider moving jsonLoad and jsonSave back into Sync's utils, and rewriting AITC to use readJSON/writeJSON, or removing AITC from the tree altogether if it's dead.

It might also be advantageous to lazy-load OS.File in CommonUtils. I don't know if that's already being loaded, and thus we don't save anything, but it might push that back to when we need to read or write.

Comment 1

[Mozilla RelEng Bot]

Try run for 67f6cbc5dca6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=67f6cbc5dca6
Results (out of 19 total builds):
    exception: 19
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-67f6cbc5dca6

Comment 2

[Richard Newman [:rnewman]]

That was a canceled try run. Yay.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Move jsonLoad and jsonSave back to Sync utils. v1

Depends on the death of AITC, of course.

Comment 4

[Richard Newman [:rnewman]]

Shaves 3120B off common utils.js. Every little helps! :D

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 708314 [details] [diff] [review]
Move jsonLoad and jsonSave back to Sync utils. v1

Review of attachment 708314 [details] [diff] [review]:
-----------------------------------------------------------------

Removed a few imports from utils.js - nice!

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/58b601eae9a7

Note that I landed Bug 836395 with this bug in the commit message. Oops.

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/8d6518406597
https://hg.mozilla.org/mozilla-central/rev/58b601eae9a7