Closed Bug 836206 Opened 9 years ago Closed 9 years ago
Split out or rewrite Common
Utils .json Load/json Save
These are the only two consumers of FileUtils and NetUtils in services/common/utils.jsm. They're only used by AITC and Sync, the former only once each. We should consider moving jsonLoad and jsonSave back into Sync's utils, and rewriting AITC to use readJSON/writeJSON, or removing AITC from the tree altogether if it's dead. It might also be advantageous to lazy-load OS.File in CommonUtils. I don't know if that's already being loaded, and thus we don't save anything, but it might push that back to when we need to read or write.
Try run for 67f6cbc5dca6 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=67f6cbc5dca6 Results (out of 19 total builds): exception: 19 Builds (or logs if builds failed) available at: http://email@example.com
That was a canceled try run. Yay.
Depends on the death of AITC, of course.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #708314 - Flags: review?(gps)
Shaves 3120B off common utils.js. Every little helps! :D
Comment on attachment 708314 [details] [diff] [review] Move jsonLoad and jsonSave back to Sync utils. v1 Review of attachment 708314 [details] [diff] [review]: ----------------------------------------------------------------- Removed a few imports from utils.js - nice!
Attachment #708314 - Flags: review?(gps) → review+
https://hg.mozilla.org/services/services-central/rev/58b601eae9a7 Note that I landed Bug 836395 with this bug in the commit message. Oops.
Whiteboard: [fixed in services][qa-]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.