Closed Bug 836395 Opened 7 years ago Closed 7 years ago

Remove AITC client

Categories

(Web Apps Graveyard :: AppsInTheCloud, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [MemShrink:P3][fixed in services][qa-])

Attachments

(1 file)

We're not doing anything with the AITC client that we ship as part of desktop Firefox, and it's a sizable chunk of code with tests and dependencies. Let's clean house a little bit, which will reduce the amount of code we have to maintain and ship, and also gives us some more flexibility in adjusting those dependencies to improve FHR.
Try build:

https://tbpl.mozilla.org/?tree=Try&rev=3535355b6102
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
We also have aitc related code in Webapps.jsm - feel free to file a followup and assign it to me.
Please make sure I've caught all of the appropriate build changes!
Attachment #708318 - Flags: review?(gps)
(In reply to Fabrice Desré [:fabrice] from comment #2)
> We also have aitc related code in Webapps.jsm - feel free to file a followup
> and assign it to me.

Will do, thanks.

I'm not sure if everything should be stripped out — I know the identity team want to address app-sync-esque features at some point, and so that'll need hooks.

We just know that AITC isn't the end state, so this code can go. Your call about how much you want to strip out of webapps itself!
Blocks: 836547
Comment on attachment 708318 [details] [diff] [review]
Proposed patch. v1

Review of attachment 708318 [details] [diff] [review]:
-----------------------------------------------------------------

It's sad we spent so much time writing this and will likely never use it. Oh well. I guess the code is always in version control if we need to resurrect it.

Some references you missed:

/configure.in
/testing/xpcshell/xpcshell.ini

::: browser/installer/removed-files.in
@@ +95,5 @@
>  defaults/pref/bug259708.js
>  defaults/pref/bug307259.js
>  defaults/pref/reporter.js
>  defaults/pref/security-prefs.js
> +defaults/pref/services-aitc.js

Are AitcComponents.manifest and Aitc.js already in this file? Add them if not (I think).
Attachment #708318 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #5)
> Comment on attachment 708318 [details] [diff] [review]
> Proposed patch. v1
> 
> Review of attachment 708318 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It's sad we spent so much time writing this and will likely never use it. Oh
> well. I guess the code is always in version control if we need to resurrect
> it.
> 
> Some references you missed:
> 
> /configure.in
> /testing/xpcshell/xpcshell.ini
> 
> ::: browser/installer/removed-files.in
> @@ +95,5 @@
> >  defaults/pref/bug259708.js
> >  defaults/pref/bug307259.js
> >  defaults/pref/reporter.js
> >  defaults/pref/security-prefs.js
> > +defaults/pref/services-aitc.js
> 
> Are AitcComponents.manifest and Aitc.js already in this file? Add them if
> not (I think).

I know you spent a lot of time and energy on this stuff, and I very much appreciate that.

I feel certain that some of this code, and the lessons we learned from it, will rise again as part of identity-attached services.
https://hg.mozilla.org/services/services-central/rev/8d6518406597

Landed with "Bug 836206" in the commit message, not this bug. Oops. That'll teach me for working at the weekend.
Whiteboard: [MemShrink] → [MemShrink][fixed in services][qa-]
Whiteboard: [MemShrink][fixed in services][qa-] → [MemShrink:P3][fixed in services][qa-]
https://hg.mozilla.org/mozilla-central/rev/8d6518406597
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Web Apps → Web Apps Graveyard
You need to log in before you can comment on or make changes to this bug.