836243 - Relax gstreamer version requirement

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ivaylo Dimitrov]

Building mozilla with gstreamer support requires gstreamer version to be at least 0.10.33 as in this version playbin2 "source-setup" signal was added. The proposed patch uses "notify::source" signal instead of "source-setup" while keeping the functionality intact. The usage of "notify::source" allows mozilla gstreamer support to be enabled on systems with gstreamer version lower than 0.10.33.

Comment 1

[Ivaylo Dimitrov]

Attachment: patch

Comment 2

[Oleg Romashin (:romaxa)]

Any updates on this bug? can we get it reviewed

Comment 3

[Alessandro Decina]

Comment on attachment 708081 [details] [diff] [review]
patch

Review of attachment 708081 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, with only one minor thing to fix

::: content/media/gstreamer/GStreamerReader.cpp
@@ +176,3 @@
>    GStreamerReader *reader = reinterpret_cast<GStreamerReader*>(aUserData);
> +
> +  g_object_get(aPlayBin, "source", &source, NULL);

this is missing a gst_object_unref(source) after the ->PlayBinSourceSetup call

Comment 4

[Alessandro Decina]

I don't seem to have permissions to approve the patch btw

Comment 5

[Alessandro Decina]

If I could, i'd make it r+ assuming the minor issue i pointed out gets fixed :)

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 708081 [details] [diff] [review]
patch

Review of attachment 708081 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me. Please upload a patch addressing the two nits.

::: content/media/gstreamer/GStreamerReader.cpp
@@ +163,5 @@
>        NULL);
>  
> +  g_signal_connect(G_OBJECT(mPlayBin), "notify::source",
> +    G_CALLBACK(GStreamerReader::PlayBinSourceSetupCb), this);
> +  

Please fix the trailing whitespace here.

Comment 7

[Ralph Giles (:rillian)]

Oops, didn't mean to clobber alessandro's r+. So much for mid-air collision detection.

Comment 8

[Ivaylo Dimitrov]

(In reply to Alessandro Decina from comment #3)
> Comment on attachment 708081 [details] [diff] [review]
> patch
> 
> Review of attachment 708081 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, with only one minor thing to fix
> 
> ::: content/media/gstreamer/GStreamerReader.cpp
> @@ +176,3 @@
> >    GStreamerReader *reader = reinterpret_cast<GStreamerReader*>(aUserData);
> > +
> > +  g_object_get(aPlayBin, "source", &source, NULL);
> 
> this is missing a gst_object_unref(source) after the ->PlayBinSourceSetup
> call

gst_object_unref is called in the class destructor:

>      gst_app_src_end_of_stream(mSource);
> +    if (mSource)
> +      gst_object_unref(mSource);

Comment 9

[Ivaylo Dimitrov]

Attachment: relax_gst_version_v1.patch

Removed extra whitespaces

Comment 10

[Oleg Romashin (:romaxa)]

Comment on attachment 713368 [details] [diff] [review]
relax_gst_version_v1.patch

Alessandro are you agree with comment #8 ?

Comment 11

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/041328ec9651

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/041328ec9651