Closed Bug 856308 Opened 12 years ago Closed 12 years ago

Enable GStreamer video buffer handling optimization for gstreamer versions older than 0.10.36

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Version:
22 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: ivo.g.dimitrov.75, Assigned: ivo.g.dimitrov.75)

References

Details

Attachments

(1 file, 3 obsolete files)

Enable GStreamer video buffer handling optimization for gstreamer versions older than 0.10.36
11.50 KB, patch
padenot
: review+
Details | Diff | Splinter Review
The patch from bug 761018 enables optimized video buffer handling only for gstreamer versions >= 0.10.36. It also uses G_DEFINE_BOXED_TYPE macro, which does not exist in GLib versions < 2.26. The proposed patch removes gstreamer version >= 0.10.36 requirement and allows optimized video buffer handling for older gstreamer versions. It also removes implicit build-time dependency on GLib >= 2.26
Attached patch patch.diff (obsolete) — — Splinter Review
Attachment #731468 - Flags: review?(alessandro.d)
Blocks: 836243
Attached patch Add missing licensing (obsolete) — — Splinter Review
Attachment #731469 - Flags: review?(alessandro.d)
Attachment #731468 - Attachment is obsolete: true
Attachment #731468 - Flags: review?(alessandro.d)
Fixed executable flags on source files, sorry for the noise
Attachment #731469 - Attachment is obsolete: true
Attachment #731469 - Flags: review?(alessandro.d)
Attachment #731470 - Flags: review?(alessandro.d)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Ping?
Attachment #731470 - Attachment description: patch.diff → Enable GStreamer video buffer handling optimization for gstreamer versions older than 0.10.36
Attachment #731470 - Attachment filename: patch.diff → CompatWith0.10.36
Re-based against latest m-c
Attachment #731470 - Attachment is obsolete: true
Attachment #731470 - Flags: review?(alessandro.d)
Attachment #742789 - Flags: review?(giles)
Comment on attachment 742789 [details] [diff] [review] Enable GStreamer video buffer handling optimization for gstreamer versions older than 0.10.36 got an initial f+ by alessandro over the IRC
Attachment #742789 - Flags: review?(giles) → review?(paul)
Attachment #742789 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/02fb8ac3f108
Assignee: nobody → freemangordon
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Blocks: 967927
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: